Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1600054147-29997-1-git-send-email-Anson.Huang@nxp.com>
 <1600054147-29997-2-git-send-email-Anson.Huang@nxp.com> <CAJKOXPfuz=vf9tCn8ZJ9dz2iAG_p61VvPWc9P=kp7nMy7tb6xw@mail.gmail.com>
 <DB3PR0402MB39168692AC262B7BFA21D0C0F5210@DB3PR0402MB3916.eurprd04.prod.outlook.com>
In-Reply-To: <DB3PR0402MB39168692AC262B7BFA21D0C0F5210@DB3PR0402MB3916.eurprd04.prod.outlook.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Wed, 16 Sep 2020 08:03:49 +0200
Message-ID: <CAJKOXPd-VZAOcezOS5-18te6OQZ53BU24su3WmAf+=Gtt8aBtw@mail.gmail.com>
Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC
 by default
To:     Anson Huang <anson.huang@nxp.com>
Cc:     "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
        "oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
        Peng Fan <peng.fan@nxp.com>,
        "andreas@kemnade.info" <andreas@kemnade.info>,
        "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
        "olof@lixom.net" <olof@lixom.net>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "prabhakar.mahadev-lad.rj@bp.renesas.com" 
        <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "lkundrak@v3.sk" <lkundrak@v3.sk>,
        "joel@jms.id.au" <joel@jms.id.au>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        Leo Li <leoyang.li@nxp.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "michael@walle.cc" <michael@walle.cc>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 16 Sep 2020 at 03:59, Anson Huang <anson.huang@nxp.com> wrote:
>
> Hi, Krzysztof
>
> > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in
> > CONFIG_GPIO_MXC by default
> >
> > On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@nxp.com>
> > wrote:
> > >
> > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> > > built-in manually.
> >
> > Maybe it should stay not enabled? Please explain in commit msg why it should
> > be enabled.
>
> The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic
> function of GPIO pin operations and IRQ operations, it is enabled by default previously
> with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly
> enabled in defconfig to make sure it does NOT break any existing functions, that is
> why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as
> built-in manually " in commit msg, it aims to NOT change any previous behaviors.

Sure, I was just saying that all this should be in commit msg. The
commit should explain why it is there in the Linux kernel.

Best regards,
Krzysztof