Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp129796pxk; Tue, 15 Sep 2020 23:23:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZaJCBINo3N7NoUGUc7hkF9jRNNSxFjlIlz+ISAKsOh61PPLLvnB2qjtv6/KPs/0zGe8OD X-Received: by 2002:a17:906:c113:: with SMTP id do19mr23193420ejc.219.1600237394851; Tue, 15 Sep 2020 23:23:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600237394; cv=none; d=google.com; s=arc-20160816; b=axNVA9WmJs6nUW09Ht/VfuJaSlvVdeZg4ZeqdT0PnAcSMEv7CjKrcY2qlA88FiIPE0 rkYwzEO4alfSkRSjeHDyl5BD2NacAgpzrB5kMrOf29xR1BKMQ/twk+EyHoyfmqQHkSmA 5GbNcIQUHfyPxD0vS/R99kIhC8QFqBXFjWXMH9Lc+vcxMM/6DvT3R/grlBDRlqg9jXXQ wzEBAnzdgOSDmHP3+e7PecoPMzHJI9qVVN4eg6H9E8oaVaXiGClK7/a2IYuDAUMAJnBe vOsiTGy01a1l9NKTqJ9CypJR4n+FmvrTMbkbvKGqP3BxAhomKCYeznW5odVcwIPIhx6m GWPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YEuDAub6lGBOQadKYlAKf/nNigT8xfTn3qnIA34NvI4=; b=epG7LiFyUbEOhij7bVADBwu6wbcG6faCS6necqYEiJ3aG2lbc1mcklVKsEf534MZTT 0nYzwbxBlMUjkupjy2jG6ZgrctfOV2i+0kYWUtSuK+xEEfmceywbXE8kbNXouQWYSKQa Dvhhsu+ufGoZYROS5JlRDtFXmhvhX6wM4RUQ/ycYQ+TMwdJWPmWKuo0nA5aD2HYhUfVp TLlH5day42/TJSLEhbgk40YhWXmKjb9gX8Ez8nbM0oWJFJg2UuNVewecg8RkjSQpqju9 KPzb8njcs0TnCtEEFkOP3AHeb29HpamPY+csLH93IKeJMLrcV8ON0l+3YR+AD1SoUYgB CC0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si10209589ejc.738.2020.09.15.23.22.52; Tue, 15 Sep 2020 23:23:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgIPGVb (ORCPT + 99 others); Wed, 16 Sep 2020 02:21:31 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12303 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726445AbgIPGVH (ORCPT ); Wed, 16 Sep 2020 02:21:07 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 63F7230A5DCB465E5511; Wed, 16 Sep 2020 14:21:05 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Wed, 16 Sep 2020 14:20:56 +0800 From: Qinglang Miao To: Greg Kroah-Hartman , Jiri Slaby , Michael Ellerman , "Benjamin Herrenschmidt" , Paul Mackerras CC: , , , Qinglang Miao Subject: [PATCH -next] serial: pmac_zilog: use for_each_child_of_node() macro Date: Wed, 16 Sep 2020 14:21:38 +0800 Message-ID: <20200916062138.191188-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use for_each_child_of_node() macro instead of open coding it. Signed-off-by: Qinglang Miao --- drivers/tty/serial/pmac_zilog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index 96e7aa479..063484b22 100644 --- a/drivers/tty/serial/pmac_zilog.c +++ b/drivers/tty/serial/pmac_zilog.c @@ -1644,7 +1644,7 @@ static int __init pmz_probe(void) * TODO: Add routines with proper locking to do that... */ node_a = node_b = NULL; - for (np = NULL; (np = of_get_next_child(node_p, np)) != NULL;) { + for_each_child_of_node(node_p, np) { if (of_node_name_prefix(np, "ch-a")) node_a = of_node_get(np); else if (of_node_name_prefix(np, "ch-b")) -- 2.23.0