Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp159688pxk; Wed, 16 Sep 2020 00:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkFOg4Wwip3EEfugNgRNgZz7pQesumSFnqoUenCxVNAcEiQITvv/6n2oKrWZ2tN+wklW2H X-Received: by 2002:a17:906:d97b:: with SMTP id rp27mr25253954ejb.18.1600241577722; Wed, 16 Sep 2020 00:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600241577; cv=none; d=google.com; s=arc-20160816; b=i2IYj49praWFsoH9hA6DRRcUBNLPeIUurXFRp8WqZ2PxhmN0mwUUPvy81rfjUxJzzi c/CdATW+Dma9Gcj3KZ+d7pFIw/RlKqwGiS63L4+baCoo/JhQto/zumPhvyXySiMdEcmR phD4JNVrc+Z+CtvLc78gAkZX2CkWVEcD1yU+/Y+K66Lfyqwk3Ss/uGYn3JB06GmvNmeg ONgDsalDI67axI+pB8LOOtPqcoHqCt94IamvV5fJDGJE9RaHovmev2d28TR57Z9BNTez aed3a6MDAgqJJehvypwxgwp7j18Lf2Un5/0LoR+HVCmKa+QdBDGzT6NGLRdBlVmmJr3o iP9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vcibQRMjLGtSU3WVdUOVdNP9BCAtXpi+CfjmiuH25/o=; b=KRimEWv50KitbXmc8kB1s2JmdGx1dFzVctez6UxTO+LcSqX1eVNU+0ZeDVm6sHtH5F Gs+Ym34DgoIV+So8bpMwP1AbQ9PUvcHPwMha0lcZOjNFmFz24HUpOCiu/aRs1hRSeRfl hDiHaqc/bixI4CaU4RsUb8s//EHs+3aob2CPL0TS0jwB+I0TOgDlO8cAjlqy1NYtwJEN ZUSGFjkC7MikooBTuxg5kysxbXVcwMj1vlrnKioBhiZjZsSyc8eSEW4za6n3WN+SLRCD Blidbirng3zfYrbcrfIy5RBTT5jp1nDqNpvXz71ysHGWrDZqt5bctMhacgkFuybxlfB9 loTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qx23si10951033ejb.355.2020.09.16.00.32.35; Wed, 16 Sep 2020 00:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbgIPHbG (ORCPT + 99 others); Wed, 16 Sep 2020 03:31:06 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:33316 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgIPHbF (ORCPT ); Wed, 16 Sep 2020 03:31:05 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A0A851C0B76; Wed, 16 Sep 2020 09:31:00 +0200 (CEST) Date: Wed, 16 Sep 2020 09:31:00 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jonathan Cameron , Angelo Compagnucci , Sasha Levin Subject: Re: [PATCH 4.19 09/78] iio: adc: mcp3422: fix locking on error path Message-ID: <20200916073100.GA32537@duo.ucw.cz> References: <20200915140633.552502750@linuxfoundation.org> <20200915140634.010489871@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <20200915140634.010489871@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > [ Upstream commit a139ffa40f0c24b753838b8ef3dcf6ad10eb7854 ] >=20 > Reading from the chip should be unlocked on error path else the lock > could never being released. >=20 > Fixes: 07914c84ba30 ("iio: adc: Add driver for Microchip MCP3422/3/4 high= resolution ADC") > Fixes: 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope") Well, 3f1093d83d71 is only applied later in the stable series, so this introduces spurious unlock. Ideally this should go just after 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope"). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --huq684BweRXVnRxX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX2G/NAAKCRAw5/Bqldv6 8ojkAJ0YrKaZTyrNMwgKA4OWczZiLBQAyACgh4hmA2LsPIoggr+YrlpdlKzXMdk= =77CW -----END PGP SIGNATURE----- --huq684BweRXVnRxX--