Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 17:00:51 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To:     Leo Yan <leo.yan@linaro.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>,
        John Garry <john.garry@huawei.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Suleiman Souhlal <suleiman@google.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] perf kvm: add kvm-stat for arm64
Message-ID: <20200916080051.GF604@jagdpanzerIV.localdomain>
References: <20200915091140.152775-1-sergey.senozhatsky@gmail.com>
 <20200915103644.GA32758@leoy-ThinkPad-X240s>
 <20200915105702.GA604@jagdpanzerIV.localdomain>
 <20200915111541.GB604@jagdpanzerIV.localdomain>
 <20200915132109.GB32758@leoy-ThinkPad-X240s>
 <20200916004404.GE604@jagdpanzerIV.localdomain>
 <20200916075154.GA13660@leoy-ThinkPad-X240s>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200916075154.GA13660@leoy-ThinkPad-X240s>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (20/09/16 15:51), Leo Yan wrote:
> On Wed, Sep 16, 2020 at 09:44:04AM +0900, Sergey Senozhatsky wrote:
> > On (20/09/15 21:21), Leo Yan wrote:
> > > 
> > > Sorry if I miss anything for this.
> > > 
> > 
> > No, you are absolutely right! I should have looked more attentively.
> > 
> > Is "IL" good enough for a decoded reason
> > 
> >  	{ARM_EXCEPTION_IRQ,		"IRQ"		},	\
> >  	{ARM_EXCEPTION_EL1_SERROR,	"SERROR"	},	\
> >  	{ARM_EXCEPTION_TRAP,		"TRAP"		},	\
> > +	{ARM_EXCEPTION_IL,		"IL"		}, \
> >  	{ARM_EXCEPTION_HYP_GONE,	"HYP_GONE"	}
> > 
> > or should there be "ILLEGAL", or maybe something even better?
> > ILLEGAL_EXC, etc.
> 
> I personally think "ILLEGAL" is neat and clear :)

OK.

By the way, arch/arm64/kernel/traps.c has esr_class_str[] with
decoded exception names. Maybe I can reuse some.

	-ss