Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp186705pxk; Wed, 16 Sep 2020 01:30:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYGJKq7uGyyHxEhdmtmPrrhz2hg1ij3fl/yyTtCfux1DIUkmJgDG8Vu6vEoXNOvrBSkc4G X-Received: by 2002:a50:c8cd:: with SMTP id k13mr26665175edh.387.1600245035998; Wed, 16 Sep 2020 01:30:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600245035; cv=none; d=google.com; s=arc-20160816; b=jAGp9iG9A2Gc80AlLX52agNtJqi6fvmLHvr1QYnKVhXaEF/PXVgiNLW1WWHICv4JGA 9x0zgC/ij3WIQfajyFUYBVWXOBtiNU0ZdZ/e1lgI5vePwWPmhGAwCqehqxUrus9T1Ija tRFhB/LCXBoHBs/IgjKBcGnz3GP4XJVSwwPE1eObkWkGk3Fjg8H8SogBfvRMr3dbHk6O izA1qM+h8pB9BYRe0xhqUO5MzxaIHixAv7rOd+RXrPIK8JFxCqVy8dpxVXKFnCRxR9dt 3UdyTLiT1Sq0gugv19HT1PhgvRyWS22NCQL6mikSFp+IHD9sLHuPD0qUL9NXfl18qdGS A9bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=0ckwD6eijNij9Cnzxb3jvArwNA5fmmUSSKzEVFQmM18=; b=YuAAY2ywkYYf2uu2jStF4PeN7CXEMCiXpVETK05At1ufqhN85k37ImELcmCOdRVM56 nx2999CiAJESi7A+VtWErN1BasvnBG42dRELYjAfxVI5/rILH4ZQTJeKKGFMv9v8L+mV tVsJG77O5g92u32iMzq2ozRz5NxVwVw71xXS2m4EMP+lN3I5KheGqKkInafOVmjdHQoG JXoMKm6AxAcC3bWBF02cYR3rareNbmVKTXwLPvfBDeeWajweu+KK8W2CsKDhYJEUMs7q 2NmBSHNic+4THsCULiiaurv9G0d5Mi7HzelPcI+8hzNnPIF3F9FnRQeemjq6bzXxZdel 441A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg23si11626015edb.229.2020.09.16.01.30.14; Wed, 16 Sep 2020 01:30:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgIPI1n (ORCPT + 99 others); Wed, 16 Sep 2020 04:27:43 -0400 Received: from inva020.nxp.com ([92.121.34.13]:48654 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726590AbgIPI0y (ORCPT ); Wed, 16 Sep 2020 04:26:54 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 021DA1A0A95; Wed, 16 Sep 2020 10:26:51 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3AC1A1A00C2; Wed, 16 Sep 2020 10:26:47 +0200 (CEST) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3A1224030D; Wed, 16 Sep 2020 10:26:42 +0200 (CEST) From: Ran Wang To: Li Yang , Rob Herring , Shawn Guo Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biwen Li , Ran Wang Subject: [PATCH 2/5] soc: fsl: handle RCPM errata A-008646 on SoC LS1021A Date: Wed, 16 Sep 2020 16:18:28 +0800 Message-Id: <20200916081831.24747-2-ran.wang_1@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916081831.24747-1-ran.wang_1@nxp.com> References: <20200916081831.24747-1-ran.wang_1@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Biwen Li Description: - Reading configuration register RCPM_IPPDEXPCR1 always return zero Workaround: - Save register RCPM_IPPDEXPCR1's value to register SCFG_SPARECR8.(uboot's psci also need reading value from the register SCFG_SPARECR8 to set register RCPM_IPPDEXPCR1) Impact: - FlexTimer module will cannot wakeup system in deep sleep on SoC LS1021A Signed-off-by: Biwen Li Signed-off-by: Ran Wang --- drivers/soc/fsl/rcpm.c | 42 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c index a093dbe..e6354f5 100644 --- a/drivers/soc/fsl/rcpm.c +++ b/drivers/soc/fsl/rcpm.c @@ -2,7 +2,7 @@ // // rcpm.c - Freescale QorIQ RCPM driver // -// Copyright 2019 NXP +// Copyright 2019-2020 NXP // // Author: Ran Wang @@ -13,6 +13,9 @@ #include #include #include +#include +#include +#include #define RCPM_WAKEUP_CELL_MAX_SIZE 7 @@ -37,6 +40,9 @@ static int rcpm_pm_prepare(struct device *dev) struct device_node *np = dev->of_node; u32 value[RCPM_WAKEUP_CELL_MAX_SIZE + 1]; u32 setting[RCPM_WAKEUP_CELL_MAX_SIZE] = {0}; + struct regmap *scfg_addr_regmap = NULL; + u32 reg_offset[2]; + u32 reg_value = 0; rcpm = dev_get_drvdata(dev); if (!rcpm) @@ -90,6 +96,40 @@ static int rcpm_pm_prepare(struct device *dev) tmp |= ioread32be(address); iowrite32be(tmp, address); } + /* + * Workaround of errata A-008646 on SoC LS1021A: + * There is a bug of register ippdexpcr1. + * Reading configuration register RCPM_IPPDEXPCR1 + * always return zero. So save ippdexpcr1's value + * to register SCFG_SPARECR8.And the value of + * ippdexpcr1 will be read from SCFG_SPARECR8. + */ + if (device_property_present(dev, "fsl,ippdexpcr1-alt-addr")) { + if (dev_of_node(dev)) { + scfg_addr_regmap = syscon_regmap_lookup_by_phandle(np, + "fsl,ippdexpcr1-alt-addr"); + } else if (is_acpi_node(dev->fwnode)) { + continue; + } + + if (scfg_addr_regmap && (i == 1)) { + if (device_property_read_u32_array(dev, + "fsl,ippdexpcr1-alt-addr", + reg_offset, + 2)) { + scfg_addr_regmap = NULL; + continue; + } + /* Read value from register SCFG_SPARECR8 */ + regmap_read(scfg_addr_regmap, + reg_offset[1], + ®_value); + /* Write value to register SCFG_SPARECR8 */ + regmap_write(scfg_addr_regmap, + reg_offset[1], + tmp | reg_value); + } + } } return 0; -- 2.7.4