Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp196363pxk; Wed, 16 Sep 2020 01:51:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuQrYlFaT+uAadHOfMbHjUXRPC8jfYRF3B2/K0tno0OOdLQfKJ3kNAt0aGwSYsgVVbZVOx X-Received: by 2002:a05:6402:5:: with SMTP id d5mr20742628edu.376.1600246264106; Wed, 16 Sep 2020 01:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600246264; cv=none; d=google.com; s=arc-20160816; b=SRLkZ/RRo1IEXgRcMSh1clwGm3+C/BwixJkfRlSxyblaW2AcVAme0fC0Z/AezSj6UQ 2sYLHGgyulYIg/Q3aG/Cmou9ZzoicohnQ+x95nzeCwk/l3g5expARt27971S+PBmaxAi uecTGIJyFWJyDFaiQ8iRIuPLAXfwDdrKnlu5aohdRp11V9ZGvtXTajvNYhMHATfpJRFf VDJu/WewQx6x3bZ8TlcO1SbFNnHuyrkhIzboLVvGg3eoQdX9D4HWnoybRfOFbDkL6RLh dcRRcYYtuJin2i1nvYgYbAE6EMp/qKB3bjmCYN5A6S+BvO6R8SJYi26gOuUDRpZKl0Mz ifzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yFjrMsePDJlQkzG4d2Vn8z/692IKzJ049uA8PvEMcO4=; b=jiCEIBemrnpDvnK/tARvePqEDbGqpQAIyTrA1wEwHjVVOsA4z5K4UhOA0/Q43NhuCj 5RKS0adf2ZeY5RhEVAhPjScPII1rCtPfTwsz6iD+tMaETJRHclZIJf5QBwhfwFt82VVY C8Y6Sy489XlL3e2r6rn0UNXXuMgQ4UWRyPDJ6PT07I4/9f5XwnveOwYMd/ZmhfGTwfwU 0t4zMybwyM64oXmCmwp7N801zYkphf89mTYyHVi3P7dIlhfI0jtPP8dLytYWz3SZ5i4v Fqpp4SmBPViOFpppEpQdLjvZrNzCR7wGI2Gky4j0zj6HJqi9fJNMfOunlZO25INY3RDr UDnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=Ncdb8mKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f27si11165536ejt.420.2020.09.16.01.50.41; Wed, 16 Sep 2020 01:51:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=Ncdb8mKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbgIPItM (ORCPT + 99 others); Wed, 16 Sep 2020 04:49:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbgIPItL (ORCPT ); Wed, 16 Sep 2020 04:49:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61BA7C06174A; Wed, 16 Sep 2020 01:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yFjrMsePDJlQkzG4d2Vn8z/692IKzJ049uA8PvEMcO4=; b=Ncdb8mKIyo2jzNf/4eaE4LnpE4 vFj38ShjIXOy8kyLU7yoLOGb+kFF78Rsm0VwpmpGVyTX3s306CGrpGaxuvnR2qMJRP/c+7onbjD2o xlf88CQo90s+kNfDXNdGx9DpBk2YXjtyBEKR057ZhUmbPSKKoohMzOxPdp7lOD776J/L8ar5x3vPr tCur5rOtVXOE1W9N7ysn155eEtqs8hrBxog4BoZUqAD++P78ZzqZzJWUKHLBbQ7CHtoPIBSnVqexZ 2weYDIUQokHvqdlyaP1xT/gi4Ao0WZ/BebOnYeahK2Pb4/KNNOKj97cffPeG/WKbGYSFx+5AdAQky jzrMrnIw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIT7l-0008Lu-46; Wed, 16 Sep 2020 08:49:09 +0000 Date: Wed, 16 Sep 2020 09:49:09 +0100 From: Christoph Hellwig To: Nick Terrell Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, squashfs-devel@lists.sourceforge.net, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Kernel Team , Nick Terrell , Chris Mason , Petr Malat , Johannes Weiner , Niket Agarwal , Yann Collet Subject: Re: [PATCH 4/9] crypto: zstd: Switch to zstd-1.4.6 API Message-ID: <20200916084909.GB31608@infradead.org> References: <20200916034307.2092020-1-nickrterrell@gmail.com> <20200916034307.2092020-5-nickrterrell@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916034307.2092020-5-nickrterrell@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + const size_t wksp_size = ZSTD_estimateCCtxSize(ZSTD_DEF_LEVEL); > + > + if (ZSTD_isError(wksp_size)) { > + ret = -EINVAL; > + goto out_free; > + } Pleas switch to properly named functions when you touch this. The API names here look like a cat threw up on the keyboard.