Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp518959pxk;
        Wed, 16 Sep 2020 09:43:25 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy/wGFnCEESx8N0TyEmVS6yV1I914qV1IBGqgAnbpQLLkBZfhCWgjQqMILOVFf+t6euZNNY
X-Received: by 2002:a17:906:8695:: with SMTP id g21mr25525159ejx.504.1600274605120;
        Wed, 16 Sep 2020 09:43:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600274605; cv=none;
        d=google.com; s=arc-20160816;
        b=Fpc+jVgkWmEYP1veT8uBqFIod4YG0vhTLO4bAHIUvBUf8IBnPZ2TmSUr2WS0tL4RaT
         7990BwwGhxly9dPiUbe7eR0JcF52IL/+cIQ3KpPUXHdZ4ODbUC48je0kSrYP93h3/v5P
         l+DRU5MzQ+8rcU/BXLxSZSk4TuOv+TtxQTAn7z1Cazi5Lkpj9P809HzcyJw3Gv1p4H8s
         Ky/LtbCmKF6qf3nZ6BXHP/rnejsNOrnSJEwlf4mKNAPMURda/JoLUGaIf67/fkQBcW/j
         aiclCufnLvLuMIPJc45D9EbSoGa2Aj6GlVKEIE3QO/SZB4mVZNNxl36MlrA1jhgdkvdH
         4vog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=gG+PE1T58uNhlilYgWwLDpb4678SxJIfy1L/ksLwJng=;
        b=dQx8adbyRFNdgfpF0kJeh/DUByFwuhQeDtdnnBKJRysd+WUEDQAchLXJxUITKrdqXt
         OSmEwpVREhZVDdOMoz4bFfUyQ1Q7r6rwap1Gc96bEBGYCr2dAuutyFweqFX3qq/BLLMz
         LJeNr8zqD1mkXkku9dhjowQzOglDYvi92By8EFPAkg646EhRZtgTh35I96CkpTjVM/xH
         h75Ysfh0Y0BOkii+eVTZHEdgp0JTGspQWtZwLUzel7hKUmwKJ4y/EWDfKwhUVzLulNpX
         OXSHCoJG5K7jY/2XL1R+VAmcyTsh/m8mLxjdIOYUKnOy9ytAB+5gBckiujmCNwP5dGZF
         yiFw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=hADaqcK9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r25si12242633edo.12.2020.09.16.09.43.01;
        Wed, 16 Sep 2020 09:43:25 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=hADaqcK9;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726554AbgIPQmP (ORCPT <rfc822;ketanpantkp@gmail.com>
        + 99 others); Wed, 16 Sep 2020 12:42:15 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:4139 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726528AbgIPQeO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Sep 2020 12:34:14 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f6233580000>; Wed, 16 Sep 2020 08:46:32 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 16 Sep 2020 08:47:14 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 16 Sep 2020 08:47:14 -0700
Received: from [10.26.74.242] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 16 Sep
 2020 15:47:02 +0000
Subject: Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard
 interrupts
To:     Marc Zyngier <maz@kernel.org>
CC:     Sumit Garg <sumit.garg@linaro.org>, <linus.walleij@linaro.org>,
        "Florian Fainelli" <f.fainelli@gmail.com>,
        Russell King <linux@arm.linux.org.uk>,
        Jason Cooper <jason@lakedaemon.net>,
        Saravana Kannan <saravanak@google.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        <linux-kernel@vger.kernel.org>,
        "Krzysztof Kozlowski" <krzk@kernel.org>,
        Will Deacon <will@kernel.org>,
        "'Linux Samsung SOC'" <linux-samsung-soc@vger.kernel.org>,
        linux-tegra <linux-tegra@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        <kernel-team@android.com>,
        Valentin Schneider <Valentin.Schneider@arm.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
References: <20200901144324.1071694-1-maz@kernel.org>
 <20200901144324.1071694-9-maz@kernel.org>
 <CGME20200914130601eucas1p23ce276d168dee37909b22c75499e68da@eucas1p2.samsung.com>
 <a917082d-4bfd-a6fd-db88-36e75f5f5921@samsung.com>
 <933bc43e-3cd7-10ec-b9ec-58afaa619fb7@nvidia.com>
 <3378cd07b92e87a24f1db75f708424ee@kernel.org>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <dcf812d9-2409-bcae-1925-e21740c2932e@nvidia.com>
Date:   Wed, 16 Sep 2020 16:46:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3378cd07b92e87a24f1db75f708424ee@kernel.org>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1600271192; bh=gG+PE1T58uNhlilYgWwLDpb4678SxJIfy1L/ksLwJng=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=hADaqcK9hCIfExdzgjcHMpJwrlobGgAZH6I578WRWVJhIEriirW/Zq4iWEGzUeTew
         zR/tz/zbHUsavCau9fsRk6LvsPRnA+IF0HYkk24dbTD6+I3quvJXI5uTzmot4lhpOP
         I+Qravh3kG5iY+FPqegiJBynPv4ry0mlJEAvCVD9RXquxrS3I0Kt5jF9XZO5AGNQbF
         lpnNPu7pDEeW5azCbPb1nXQOy1MhFJBXIG2o149MxGD8ZjuOk62fsEr2CwLse2RrlY
         sODoyOrb0nbWL1kQQZJKUEleKLzua93p8gCr3JrRj/1408BVKh7DtiyqzqLY3WBJtp
         xWiZsuxGVQrWw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 16/09/2020 16:10, Marc Zyngier wrote:
> Hi Jon,
>=20
> +Linus, who is facing a similar issue.
>=20
> On 2020-09-16 15:16, Jon Hunter wrote:
>> Hi Marc,
>>
>> On 14/09/2020 14:06, Marek Szyprowski wrote:
>>> Hi Marc,
>>>
>>> On 01.09.2020 16:43, Marc Zyngier wrote:
>>>> Change the way we deal with GIC SGIs by turning them into proper
>>>> IRQs, and calling into the arch code to register the interrupt range
>>>> instead of a callback.
>>>>
>>>> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
>>>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>>> This patch landed in linux next-20200914 as commit ac063232d4b0
>>> ("irqchip/gic: Configure SGIs as standard interrupts"). Sadly it breaks
>>> booting of all Samsung Exynos 4210/4412 based boards (dual/quad ARM
>>> Cortex A9 based). Here are the last lines from the bootlog:
>>
>> I am observing the same thing on several Tegra boards (both arm and
>> arm64). Bisect is pointing to this commit. Reverting this alone does not
>> appear to be enough to fix the issue.
>=20
> Right, I am just massively by the GICv3 spec, and failed to remember
> that ye olde GIC exposes the source CPU in AIR *and* wants it back, while
> newer GICs deal with that transparently.
>=20
> Can you try the patch below and let me know?

Yes will do.

> @@ -365,14 +354,13 @@ static void __exception_irq_entry
> gic_handle_irq(struct pt_regs *regs)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
smp_rmb();
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
/*
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * Samsung's funky GIC encodes the source CPU in
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * GICC_IAR, leading to the deactivation to fail if
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * not written back as is to GICC_EOI.=C2=A0 Stash the
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * INTID away for gic_eoi_irq() to write back.
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * This only works because we don't nest SGIs...
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * The GIC encodes the source CPU in GICC_IAR,
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * leading to the deactivation to fail if not
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * written back as is to GICC_EOI.=C2=A0 Stash the INTID
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * away for gic_eoi_irq() to write back.=C2=A0 This only
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 * works because we don't nest SGIs...
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 */
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (i=
s_frankengic())
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 set_sgi_intid(irqstat);
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this_=
cpu_write(sgi_intid, intid);

I assume that it should be irqstat here and not intid?

Cheers
Jon

--=20
nvpublic