Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 09:38:40 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Oded Gabbay <oded.gabbay@gmail.com>
Cc:     Omer Shpigelman <oshpigelman@habana.ai>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        SW_Drivers <SW_Drivers@habana.ai>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC
Message-ID: <20200916093840.27112c98@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <CAFCwf12o71waoJ9T5kL=M-re8+LzRk+EuzbJARB22wk6+ypQdw@mail.gmail.com>
References: <20200910161126.30948-1-oded.gabbay@gmail.com>
        <20200910161126.30948-13-oded.gabbay@gmail.com>
        <20200910130138.6d595527@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <CAFCwf113A_=da2fGxgMbq_V0OcHsxdp5MpfHiUfeew+gEdnjaQ@mail.gmail.com>
        <20200910131629.65b3e02c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <CAFCwf10XdCDhLeyiArc29PAJ_7=BGpdiUvFRotvFHieiaRn=aA@mail.gmail.com>
        <20200910133058.0fe0f5e3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <AM0PR02MB552316B9A1635C18F8464116B8230@AM0PR02MB5523.eurprd02.prod.outlook.com>
        <20200914095018.21808fae@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <CAFCwf12o71waoJ9T5kL=M-re8+LzRk+EuzbJARB22wk6+ypQdw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 15 Sep 2020 15:57:16 +0300 Oded Gabbay wrote:
> On Mon, Sep 14, 2020 at 7:50 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > What's the use for a networking device which only communicates with
> > itself, other than testing?  
> 
> No use, and we do have a suite of tests that runs from user-space on
> the device after we move the interfaces to loopback mode.
> The main problem, as Omer said, is that we have two H/W bugs:
> 
> 1. Where you need to reset the entire SoC in case you want to move a
> single interface into (or out of) loopback mode. So doing it via
> ethtool will cause a reset to the entire SoC, and if you want to move
> all 10 ports to loopback mode, you need to reset the device 10 times
> before you can actually use that.
> 
> 2. Our 10 ports are divided into 5 groups of 2 ports each, from H/W
> POV. That means if you move port 0 to loopback mode, it will affect
> port 1 (and vice-versa). I don't think we want that behavior.
> 
> That's why we need this specific exception to the rule and do it via
> debugfs. I understand it is not common practice, but due to H/W bugs
> we can't workaround, we ask this exception.

Are those tests open source?

Are you sure you need this upstream? Are your users going to run those
tests?