Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200916152909.6812-1-vadym.kochan@plvision.eu>
In-Reply-To: <20200916152909.6812-1-vadym.kochan@plvision.eu>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 16 Sep 2020 17:39:54 +0200
Message-ID: <CAMpxmJV3Rq65SY4MvLc8ONcpzt4DGZ3Kz5GpGi0TGZqHcJPWwg@mail.gmail.com>
Subject: Re: [PATCH] misc: eeprom: set type id as EEPROM for nvmem devices
To:     Vadym Kochan <vadym.kochan@plvision.eu>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 16, 2020 at 5:29 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
>
> Set type as NVMEM_TYPE_EEPROM to expose this info via
> sysfs:
>
> $ cat /sys/bus/nvmem/devices/0-00560/type
> EEPROM
>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> ---
> Checked only with at24.
>
>  drivers/misc/eeprom/at24.c          | 1 +
>  drivers/misc/eeprom/at25.c          | 1 +
>  drivers/misc/eeprom/eeprom_93xx46.c | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 2591c21b2b5d..800300296c74 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -678,6 +678,7 @@ static int at24_probe(struct i2c_client *client)
>                         return err;
>         }
>
> +       nvmem_config.type = NVMEM_TYPE_EEPROM;
>         nvmem_config.name = dev_name(dev);
>         nvmem_config.dev = dev;
>         nvmem_config.read_only = !writable;
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index ed8d38b09925..3a586a7c4b1a 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -348,6 +348,7 @@ static int at25_probe(struct spi_device *spi)
>         spi_set_drvdata(spi, at25);
>         at25->addrlen = addrlen;
>
> +       at25->nvmem_config.type = NVMEM_TYPE_EEPROM;
>         at25->nvmem_config.name = dev_name(&spi->dev);
>         at25->nvmem_config.dev = &spi->dev;
>         at25->nvmem_config.read_only = chip.flags & EE_READONLY;
> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
> index 94cfb675fe4e..7c45f82b4302 100644
> --- a/drivers/misc/eeprom/eeprom_93xx46.c
> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
> @@ -455,6 +455,7 @@ static int eeprom_93xx46_probe(struct spi_device *spi)
>         edev->pdata = pd;
>
>         edev->size = 128;
> +       edev->nvmem_config.type = NVMEM_TYPE_EEPROM;
>         edev->nvmem_config.name = dev_name(&spi->dev);
>         edev->nvmem_config.dev = &spi->dev;
>         edev->nvmem_config.read_only = pd->flags & EE_READONLY;
> --
> 2.17.1
>

Please split it into separate patches - these drivers have different
maintainers.

Bartosz