Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 13:58:14 -0400
From:   Aristeu Rozanski <aris@ruivo.org>
To:     osalvador@suse.de
Cc:     naoya.horiguchi@nec.com, akpm@linux-foundation.org,
        mhocko@kernel.org, tony.luck@intel.com, cai@lca.pw,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups
Message-ID: <20200916175813.GD17169@cathedrallabs.org>
References: <20200914101559.17103-1-osalvador@suse.de>
 <20200915212222.GA18315@cathedrallabs.org>
 <20200916072658.GA10692@linux>
 <20200916135358.GB17169@cathedrallabs.org>
 <20200916140921.GA17949@linux>
 <20200916144603.GC17169@cathedrallabs.org>
 <9bd7ac81968a7897474804d53bfc1286@suse.de>
 <f9163730a1cd3480788e53a2153d2ea3@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f9163730a1cd3480788e53a2153d2ea3@suse.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 16, 2020 at 06:34:52PM +0200, osalvador@suse.de wrote:
> Fat fingers, sorry:
> 
> Ok, this is something different.
> The race you saw previously is kinda normal as there is a race window 
> between spotting a freepage and taking it off the buddy freelists.
> The retry patch should help there.
> 
> The issue you are seeing right here is due to the call to 
> page_handle_poison in __soft_offline_page being wrong, as we pass 
> hugepage_or_freepage = true inconditionally, which is wrong.
> I think it was caused during rebasing.
> 
> Should be:

Tests passed with this patch on top of others.
Thanks!

-- 
Aristeu