Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp581256pxk; Wed, 16 Sep 2020 11:20:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBUKmKdY6jcb4TCnNfn2eu9pEES7nsTOlw5So/RQmzjp4cNefBX5Rlm3aQhonrmUSCGZl5 X-Received: by 2002:a17:906:2e14:: with SMTP id n20mr27617690eji.214.1600280405685; Wed, 16 Sep 2020 11:20:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600280405; cv=none; d=google.com; s=arc-20160816; b=toCt9yvr2POnewGa7BJjgw5D8TrjfonZA6vaz7E9mJAI4c4VDexGPeg/XQdP8J4QcS TMlCnyzqWrapmnXBOBDQHA0CEbf2GAUOmQiwrylml0zEiP24RxJgsTEk5zLs2X/cRYYm ikbWg6f264jvdfHj7nHRvuAZ6BssPq6ygpOmTt6hBBALjkO8vBxCFXI+daOfiLwd67lO mtigenk0VL4x4oGpTxHYvu51HSR/SW22CfCHnZHpG+eRCxo1kFfbOPO4HeAD0cRsvmWZ 91vihK2l9venJ7Jx6g0z9795DacB7gykv+UjbnKqdwMTFE2y5dTgOjfRIsVR5TjUVr3E NsAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7H+IyAznO8LQr+RxhFcvLwxbzz5Zv6pqKDEeCqzOWp4=; b=nmNU7Q0wZBhfJksAScO3oVYoq4wntG3DQkQndMVNX1femN7px7Tna92M5c9Cc3W4TM n7C/12lvvzk4F5ujs3UcTqlncc202204qiNtNPOhN8YuQQEQ2uE687Ifs93j+pzBeX2C LG6ALVKNVO9nVnxilcAYlSH3mxdpH9oMqfIvJoZ/O/oeXeucfEDrHFV2JnzqhaGyh+tq pyhJYM3fjKqdO0kka0VcGcgtdOspCJfPDTQawuZg/nzitQUS1Yhh7ZBPL5oXdztSoIAQ oRj4rTKLJ+7NlNAalJE6OjH5UcXaaI6pIAYuodR9gjQ8K7Nvo5sbnnODbopqMADmazSd z7gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=weYbHppD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si12121918edq.370.2020.09.16.11.19.42; Wed, 16 Sep 2020 11:20:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=weYbHppD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727913AbgIPSSh (ORCPT + 99 others); Wed, 16 Sep 2020 14:18:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727899AbgIPSSD (ORCPT ); Wed, 16 Sep 2020 14:18:03 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E45821655; Wed, 16 Sep 2020 18:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600280282; bh=RYA2LrqTsqrb7hEDg4AHEnfPPnO9ZBUXZ0TGxhqVARc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=weYbHppDCrwYigvxNzFvcXpvJJT9ohm168FMXhRF34I2B0QXIuLTU78BOBxx0ctSz 0XPZ17WLiS/WQeeIr/AtQoMWi/n66lqxwbUmRR/xpOsJtp3llOJEqb8t/ufX2G/WgK t2hIYQEN6FC8J4NJYlB5rFylTFXC4VhFPv02H0FA= Date: Wed, 16 Sep 2020 19:17:56 +0100 From: Jonathan Cameron To: Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-iio@vger.kernel.org, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent Message-ID: <20200916191756.6f53853a@archlinux> In-Reply-To: <20200915192621.13202-1-martin.blumenstingl@googlemail.com> References: <20200915192621.13202-1-martin.blumenstingl@googlemail.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2020 21:26:21 +0200 Martin Blumenstingl wrote: > Use only one line for the closing bracket of the last entry and the > opening bracket for the next one to keep the style across the whole > array consistent. Also add a "sentinel" comment to the last entry and > remove the comma to ensure that there won't be any entry after it. > No functional changes. > > Signed-off-by: Martin Blumenstingl Applied, Thanks, Jonathan > --- > drivers/iio/adc/meson_saradc.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index 95bd187de1cb..e03988698755 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = { > { > .compatible = "amlogic,meson8-saradc", > .data = &meson_sar_adc_meson8_data, > - }, > - { > + }, { > .compatible = "amlogic,meson8b-saradc", > .data = &meson_sar_adc_meson8b_data, > - }, > - { > + }, { > .compatible = "amlogic,meson8m2-saradc", > .data = &meson_sar_adc_meson8m2_data, > - }, > - { > + }, { > .compatible = "amlogic,meson-gxbb-saradc", > .data = &meson_sar_adc_gxbb_data, > }, { > @@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = { > .compatible = "amlogic,meson-g12a-saradc", > .data = &meson_sar_adc_g12a_data, > }, > - {}, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match); >