Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 19:10:26 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     Hartmut Knaack <knaack.h@gmx.de>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] iio: adc: palmas_gpadc: use
 module_platform_driver to simplify the code
Message-ID: <20200916191026.56932e1c@archlinux>
In-Reply-To: <20200914065401.3726354-1-liushixin2@huawei.com>
References: <20200914065401.3726354-1-liushixin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 14 Sep 2020 14:54:01 +0800
Liu Shixin <liushixin2@huawei.com> wrote:

> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/palmas_gpadc.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index 1ca6570be66a..889b88768b63 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -834,18 +834,7 @@ static struct platform_driver palmas_gpadc_driver = {
>  		.of_match_table = of_palmas_gpadc_match_tbl,
>  	},
>  };
> -
> -static int __init palmas_gpadc_init(void)
> -{
> -	return platform_driver_register(&palmas_gpadc_driver);
> -}
> -module_init(palmas_gpadc_init);
> -
> -static void __exit palmas_gpadc_exit(void)
> -{
> -	platform_driver_unregister(&palmas_gpadc_driver);
> -}
> -module_exit(palmas_gpadc_exit);
> +module_platform_driver(palmas_gpadc_driver);
>  
>  MODULE_DESCRIPTION("palmas GPADC driver");
>  MODULE_AUTHOR("Pradeep Goudagunta<pgoudagunta@nvidia.com>");