Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200727085132.29754-1-gengcixi@gmail.com> <CAF12kFuss4AQZSBX+A2G_fWjka3C4kpf4iDWU9QJY=AWigoxqg@mail.gmail.com>
In-Reply-To: <CAF12kFuss4AQZSBX+A2G_fWjka3C4kpf4iDWU9QJY=AWigoxqg@mail.gmail.com>
From:   Cixi Geng <gengcixi@gmail.com>
Date:   Wed, 16 Sep 2020 20:55:45 +0800
Message-ID: <CAF12kFtPQ0bUKrr4X8MjLCTfFYkRVk6BRaLb30W59GwtWQd6xA@mail.gmail.com>
Subject: Re: [PATCH V7] GCOV: Add config to check the preqequisites situation
To:     Greg KH <gregkh@linuxfoundation.org>, jslaby@suse.com,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-serial@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     Orson Zhai <orsonzhai@gmail.com>, zhang.lyra@gmail.com,
        Cixi Geng <cixi.geng1@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi ALL=EF=BC=9A
Not recieve more advise for a long time ,
Can this submission be merged recently?

Cixi Geng <gengcixi@gmail.com> =E4=BA=8E2020=E5=B9=B48=E6=9C=8820=E6=97=A5=
=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=888:40=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi All:
>
> Does this patch need more modification?
>
> <gengcixi@gmail.com> =E4=BA=8E2020=E5=B9=B47=E6=9C=8827=E6=97=A5=E5=91=A8=
=E4=B8=80 =E4=B8=8B=E5=8D=884:51=E5=86=99=E9=81=93=EF=BC=9A
> >
> > From: Cixi Geng <cixi.geng1@unisoc.com>
> >
> > Introduce new configuration option GCOV_PROFILE_PREREQS that can be
> > used to check whether the prerequisites for enabling gcov profiling
> > for specific files and directories are met.
> >
> > Only add SERIAL_GCOV for an example.
> >
> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> > ---
> >  drivers/tty/serial/Kconfig  |  7 +++++++
> >  drivers/tty/serial/Makefile |  1 +
> >  kernel/gcov/Kconfig         | 12 ++++++++++++
> >  3 files changed, 20 insertions(+)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 780908d43557..55b128b6b31d 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1576,3 +1576,10 @@ endmenu
> >
> >  config SERIAL_MCTRL_GPIO
> >         tristate
> > +
> > +config SERIAL_GCOV
> > +       bool "Enable profile gcov for serial directory"
> > +       depends on GCOV_PROFILE_PREREQS
> > +       help
> > +         The SERIAL_GCOV will add Gcov profiling flags when kernel com=
piles.
> > +         Say 'Y' here if you want the gcov data for the serial directo=
ry,
> > diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> > index d056ee6cca33..17272733db95 100644
> > --- a/drivers/tty/serial/Makefile
> > +++ b/drivers/tty/serial/Makefile
> > @@ -3,6 +3,7 @@
> >  # Makefile for the kernel serial device drivers.
> >  #
> >
> > +GCOV_PROFILE :=3D $(CONFIG_SERIAL_GCOV)
> >  obj-$(CONFIG_SERIAL_CORE) +=3D serial_core.o
> >
> >  obj-$(CONFIG_SERIAL_EARLYCON) +=3D earlycon.o
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index 3110c77230c7..bb2e1fb85743 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -51,4 +51,16 @@ config GCOV_PROFILE_ALL
> >         larger and run slower. Also be sure to exclude files from profi=
ling
> >         which are not linked to the kernel image to prevent linker erro=
rs.
> >
> > +config GCOV_PROFILE_PREREQS
> > +       bool "Profile Kernel for prereqs"
> > +       depends on GCOV_KERNEL
> > +       depends on  !COMPILE_TEST
> > +       def_bool y if GCOV_KERNEL && !COMPILE_TEST
> > +       help
> > +         This options activates profiling for the specified kernel mod=
ules.
> > +
> > +         When some modules need Gcov data, enable this config, then co=
nfigure
> > +         with gcov on the corresponding modules,The directories or fil=
es of
> > +         these modules will be added profiling flags after kernel comp=
ile.
> > +
> >  endmenu
> > --
> > 2.17.1
> >