Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d9064a334a680ac9eee0ff62c66863637099e93b.camel@redhat.com>
Subject: Re: [RFC] autonuma: Migrate on fault among multiple bound nodes
From:   Qian Cai <cai@redhat.com>
To:     David Hildenbrand <david@redhat.com>,
        Huang Ying <ying.huang@intel.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Michal Hocko <mhocko@suse.com>,
        David Rientjes <rientjes@google.com>
Date:   Wed, 16 Sep 2020 11:35:16 -0400
In-Reply-To: <91cfda06-0286-cb36-01fb-23cf28facee4@redhat.com>
References: <20200916005936.232788-1-ying.huang@intel.com>
         <2fe2a22235a0474b4a3de939cc22c19affc945fd.camel@redhat.com>
         <91cfda06-0286-cb36-01fb-23cf28facee4@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-09-16 at 17:29 +0200, David Hildenbrand wrote:
> On 16.09.20 15:39, Qian Cai wrote:
> > On Wed, 2020-09-16 at 08:59 +0800, Huang Ying wrote:
> > >  static int apply_policy_zone(struct mempolicy *policy, enum zone_type
> > > zone)
> > > @@ -2474,11 +2481,13 @@ int mpol_misplaced(struct page *page, struct
> > > vm_area_struct *vma, unsigned long
> > >  	int thisnid = cpu_to_node(thiscpu);
> > >  	int polnid = NUMA_NO_NODE;
> > >  	int ret = -1;
> > > +	bool moron;
> > 
> > Are you really going to use that name those days?
> > 
> > 
> 
> include/uapi/linux/mempolicy.h:#define MPOL_F_MORON     (1 << 4) /*
> Migrate On protnone Reference On Node */
> 
> Not commenting the decision for that name. It's uapi ... and naming the
> variable like the uapi flag seems to be a sane thing to do ... hmmm ...

One can argue there is no need to enforce that past decision today. Also, it
could be total different thing with a prefix and all capital letters (correct
for abbreviation). Anyway, not going to insist on it at all.