Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 14:22:36 -0500
From:   Wei Huang <wei.huang2@amd.com>
To:     "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>, Wei Huang <whuang2@amd.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] KVM: x86: allow for more CPUID entries
Message-ID: <20200916192236.GA623906@weilap>
References: <20200915154306.724953-1-vkuznets@redhat.com>
 <20200915165131.GC2922@work-vm>
 <20200916034905.GA508748@weilap>
 <20200916083351.GA2833@work-vm>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200916083351.GA2833@work-vm>
Importance: high
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (24.55.15.93) by BL0PR01CA0024.prod.exchangelabs.com (2603:10b6:208:71::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Wed, 16 Sep 2020 19:22:39 +0000
X-Priority: 1 (Highest)
X-MSMail-Priority: High
X-Originating-IP: [24.55.15.93]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: c142b2e8-9e00-4aaf-c49c-08d85a75e0b6
X-MS-TrafficTypeDiagnostic: CY4PR12MB1925:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CY4PR12MB1925CDB14B82D5D6A30DEBABCF210@CY4PR12MB1925.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: AFMQVTw7SyB8KcaAxGwWyGyxKoOdKmWzpwOSOErGqQUdQBB+AYxJLNIqaMt58RLUctVC+96fionxmKlkp3HGgSLb+edvnF+907LRLWueA1crt5SpD/11TRxC/86xIaUuQzYD3JbDRgMj0n0KXAx+QfI01e1IvfEUsBQxX5AuR96t3Cx9HYVvG+F4H3J8Ku6PQD7tNuGYQh0xXcvTXb1orcPz3VNiRAESIcDRlx7D2ez9Q+FCp9QXBcbp5ieE0WnSW7bk2YENZAZS/IxurWQKlTwwbs/HYqTijJl2LOyKJ8eqxAs0xEbWoAwbGkVbq7JioXx8IoTj4GtqKjk+cgYd/g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR12MB1494.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(136003)(396003)(366004)(346002)(376002)(39860400002)(16526019)(5660300002)(6496006)(2906002)(8936002)(186003)(83380400001)(33656002)(66476007)(8676002)(86362001)(54906003)(6916009)(6666004)(66556008)(66946007)(52116002)(316002)(33716001)(4326008)(478600001)(956004)(26005)(9686003)(6486002)(1076003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: GSik7Z01MMOA4QkghMVs7B0L0bS43du6Lk/TIQsPX7TjI5oX1l/6++/PCDVjUvYgbuoKsPSDuMobxelxWCQQqasUv8sLjFNa/LV+iNtxPY5VA/GcbH92UEOfeJlfNISr/sCa2vju2KGZZQHipvPU8V7VYjVA9vHGhFFkP6YPSTxiUwaeGm6Mk+7sM/RO33p7woqRLNjwBJBD6fhyjGgX3gk27nBs4lCMiX+XHwowo5ii8n3QC4dcHcaS3krd7SKkiUbukgmFR4OiGMrhnDmt9FewX3xUh0A2V/OGTsKKOl1DUlqreMsM85IYbW3mBQ1TajyMlB00zgtUTlGQmQ9iFMHOYiKTEZfLYLkH18n13VsBM9zr9JzrvPeWBiKV9kn1JQWB2Ahdej3fPE01gYQ/U7d+MGmLWzWj8+VQT7kA80U8IutG8PcLuLyO4lLwspXz/QEGuaHeSWGsE+KjXGycZCm7Ln7uwq3aLD1HdPq2VYVsRCkVJpjpormeHSExZZomUskJTCjn8J4tOBB4sFezPH6hKj3G9hxaY/aZTW4kO8YAWt7grsbg7s6LO9AbGlaWhdo+jeSjot9jLURklrBmbcQvVFT7zSqV5Gx1nrqejOf+mLMZVTsX5cPLHVzAx9RtVupRRt8Hko5Cl6hF4kPuYQ==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c142b2e8-9e00-4aaf-c49c-08d85a75e0b6
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1494.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2020 19:22:40.5160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5tvCRj19Y0kGe3Itfrjk64X+0cVmRgTA1GAW89i1SfTJjapzAnjPCumdhZLb1gmM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1925
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/16 09:33, Dr. David Alan Gilbert wrote:
> * Wei Huang (wei.huang2@amd.com) wrote:
> > On 09/15 05:51, Dr. David Alan Gilbert wrote:
> > > * Vitaly Kuznetsov (vkuznets@redhat.com) wrote:
> > > > With QEMU and newer AMD CPUs (namely: Epyc 'Rome') the current limit for
> > 
> > Could you elaborate on this limit? On Rome, I counted ~35 CPUID functions which
> > include Fn0000_xxxx, Fn4000_xxxx and Fn8000_xxxx.
> 
> On my 7302P the output of:
>     cpuid -1 -r | wc -l
> 
> is 61, there is one line of header in there.
> 
> However in a guest I see more; and I think that's because KVM  tends to
> list the CPUID entries for a lot of disabled Intel features, even on
> AMD, e.g. 0x11-0x1f which AMD doesn't have, are listed in a KVM guest.
> Then you add the KVM CPUIDs at 4...0 and 4....1.
>

It is indeed a mixing bag. Some are added even though AMD CPU doesn't define
them. BTW I also believe that cpuid command lists more CPUIDs than the real
value of cpuid->nent in kvm_vcpu_ioctl_set_cpuid(2).

Anyway I don't have objection to this patchset.

> IMHO we should be filtering those out for at least two reasons:
>   a) They're wrong
>   b) We're probably not keeping the set of visible CPUID fields the same
>     when we move between host kernels, and that can't be good for
> migration.
> 
> Still, those are separate problems.
> 
> Dave
> 
> > > > KVM_MAX_CPUID_ENTRIES(80) is reported to be hit. Last time it was raised
> > > > from '40' in 2010. We can, of course, just bump it a little bit to fix
> > > > the immediate issue but the report made me wonder why we need to pre-
> > > > allocate vcpu->arch.cpuid_entries array instead of sizing it dynamically.
> > > > This RFC is intended to feed my curiosity.
> > > > 
> > > > Very mildly tested with selftests/kvm-unit-tests and nothing seems to
> > > > break. I also don't have access to the system where the original issue
> > > > was reported but chances we're fixing it are very good IMO as just the
> > > > second patch alone was reported to be sufficient.
> > > > 
> > > > Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > 
> > > Oh nice, I was just going to bump the magic number :-)
> > > 
> > > Anyway, this seems to work for me, so:
> > > 
> > > Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > 
> > 
> > I tested on two platforms and the patches worked fine. So no objection on the
> > design.
> > 
> > Tested-by: Wei Huang <wei.huang2@amd.com>
> > 
> > > > Vitaly Kuznetsov (2):
> > > >   KVM: x86: allocate vcpu->arch.cpuid_entries dynamically
> > > >   KVM: x86: bump KVM_MAX_CPUID_ENTRIES
> > > > 
> > > >  arch/x86/include/asm/kvm_host.h |  4 +--
> > > >  arch/x86/kvm/cpuid.c            | 55 ++++++++++++++++++++++++---------
> > > >  arch/x86/kvm/x86.c              |  1 +
> > > >  3 files changed, 43 insertions(+), 17 deletions(-)
> > > > 
> > > > -- 
> > > > 2.25.4
> > > > 
> > > -- 
> > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > > 
> > 
> -- 
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>