Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp647515pxk; Wed, 16 Sep 2020 13:14:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUU78JiqfbUnreNju5u1VcZKvTrF7PqlEJtzRx9vxxMZj6uYq9WZ51N6tYrtM4/VsCFMlc X-Received: by 2002:a05:6402:cb4:: with SMTP id cn20mr29734401edb.369.1600287281379; Wed, 16 Sep 2020 13:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600287281; cv=none; d=google.com; s=arc-20160816; b=wGHD0VF/xqv9AN5OluiYEWT1lyoLej4UDNtfBc3t8PQVhMUL9S+AaRgGpLwv56rhaK AbT2JLyzKf3t6vZGE3/+lvez/8+hTJSEVGnDDUdBxf3D1LSQ9DxwZoPobZwbDlOvxTCX YsP6cOi+zwKEWLuBsBrDYi2nkctfa7V0MSEKMcCmnlj93DvmP2yA80nPjcq/xZuhsDwN htppTrHIJD5WDFE/KLMt2ixm1BTPbn+oJBG4IK35txRo6Wus0+/sDpnhUizuVEgOF6aw qr+4bhNzhqyN1RQ3zDfg1V35xldk37K1K4u+w9J/Ti/2NqUEm1XvBqP2JPvA/XnDHynf TX9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iOewzx0cq2nF+vi7XrYPviq7jviggyZalPWUXR0E1Rg=; b=gZ1eQQT91LLSNCKxsNkyNjY6UBPVN+OhMu8A65/H8HGqEgAJA2aYJX9qrbfHB1v4ub jWcxBdV5C70P+dPvfXRY3asbMkz68ukdmCd2Mmg5rsSdK/zZIXfM6+JSuxhhBH0S6jsH hZd7dpnGkDp9BGNfA407rviyZRcTHO8gH6WGJZs3zrkpne3bid1chy6grOO71JzLxxr7 C7MbLdT7FM3J5RTsDE6pVI2iI1/LScpYM5Gng3TmvVUGpFf4wJuJ1bbWp2W9e6+Eqoq3 BJAUqPI8gYIO6FT5wIkV6SwW9hgfnppCk/FX7LNuJbGgqb2jAbAUdZH6NJ1uP5fc9LWi Jnng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df4si12140021edb.378.2020.09.16.13.14.17; Wed, 16 Sep 2020 13:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbgIPULK (ORCPT + 99 others); Wed, 16 Sep 2020 16:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727193AbgIPRdl (ORCPT ); Wed, 16 Sep 2020 13:33:41 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D355C0073E2 for ; Wed, 16 Sep 2020 06:58:23 -0700 (PDT) Received: from bigeasy by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kIXwv-0004I7-Ps; Wed, 16 Sep 2020 15:58:17 +0200 Date: Wed, 16 Sep 2020 15:58:17 +0200 From: Sebastian Andrzej Siewior To: peterz@infradead.org Cc: mingo@kernel.org, vincent.guittot@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bristot@redhat.com, swood@redhat.com, valentin.schneider@arm.com Subject: Re: [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run during hotplug Message-ID: <20200916135817.3djsqmziqvzo6hmq@flow> References: <20200911081745.214686199@infradead.org> <20200911082536.528661716@infradead.org> <20200916101845.5ikjhfk27bgvs3pe@flow> <20200916121020.GP2674@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200916121020.GP2674@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-16 14:10:20 [+0200], peterz@infradead.org wrote: squeeze that in please: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index a4fe22b8b8418..bed3cd28af578 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6866,7 +6866,7 @@ static int __balance_push_cpu_stop(void *arg) raw_spin_lock_irq(&p->pi_lock); rq_lock(rq, &rf); - update_rq_clock(); + update_rq_clock(rq); if (task_rq(p) == rq && task_on_rq_queued(p)) { cpu = select_fallback_rq(rq->cpu, p); and count me in :) Sebastian