Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 16:07:30 +0200
From:   peterz@infradead.org
To:     Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc:     mingo@kernel.org, vincent.guittot@linaro.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bristot@redhat.com, swood@redhat.com,
        valentin.schneider@arm.com
Subject: Re: [PATCH 2/2] sched/hotplug: Ensure only per-cpu kthreads run
 during hotplug
Message-ID: <20200916140730.GB1362448@hirez.programming.kicks-ass.net>
References: <20200911081745.214686199@infradead.org>
 <20200911082536.528661716@infradead.org>
 <20200916101845.5ikjhfk27bgvs3pe@flow>
 <20200916121020.GP2674@hirez.programming.kicks-ass.net>
 <20200916135817.3djsqmziqvzo6hmq@flow>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200916135817.3djsqmziqvzo6hmq@flow>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 16, 2020 at 03:58:17PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-09-16 14:10:20 [+0200], peterz@infradead.org wrote:
> 
> squeeze that in please:
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a4fe22b8b8418..bed3cd28af578 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6866,7 +6866,7 @@ static int __balance_push_cpu_stop(void *arg)
>  	raw_spin_lock_irq(&p->pi_lock);
>  	rq_lock(rq, &rf);
>  
> -	update_rq_clock();
> +	update_rq_clock(rq);
>  
>  	if (task_rq(p) == rq && task_on_rq_queued(p)) {
>  		cpu = select_fallback_rq(rq->cpu, p);
> 
> 
> and count me in :)

Duh... /me goes in search of the brown paper bag -- again!