Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp666962pxk; Wed, 16 Sep 2020 13:51:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz30nc4mWO0Mdl5QCiw02l5s5DKmQm1uFBTfFjAme/am7q/ftOfGGTm4SaLV470AEzKAw6n X-Received: by 2002:a17:906:580a:: with SMTP id m10mr27230789ejq.200.1600289512681; Wed, 16 Sep 2020 13:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600289512; cv=none; d=google.com; s=arc-20160816; b=LXuD+irim5evR/4igLwXgMLjdpZDZ+rflLl6Ivynkbj5L4z7OzO5goY3MVCIMCM9nI EsqsgV7q0XqeX+nv0aaxFRuUg65Kd7WPXiwbWGEjAfOpYlPBbrc7L94SloVQxIwKmELA nrxmlIkTOVrGxKBiBwwso51u3hzNnP1okDAk20uW77zfs1PzXylilDl5iETkSqcywl9z RY94sjMADTARKI2/XVONhQgALd3sNKvXlF2d8GJb4oIZB2AI08Z2xmMoLDaLkZH0j9al 62n5+nYZnedE0i72Ge7rXcGFEQJ5heTLnfO/h7NARqWyzKTvKxnW0OdQdzxNthp2U6AR Qrjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :dkim-signature; bh=6OX2minHfjzVyBOJQrdaqKGWzfqGpYJXESyQtwYpeWk=; b=0vVGBj5K9HiU2OPwzheT07F54WT+MmbLUHHDefrmX/jyhlVLqxvtV8h9tHr7O3TqvB 0vkuaLbXl2xN2ZI05+kdL2QWxIUORqU3XgL0ITPupo74PMVMheft/J1ZR1UaxK6DbpqZ 4h5xbZsSyCaUtT3WSlzxczKamfR7w4netuwsOE/s+FqTmBoP7ZNZPS7D+ABpyNqtrV3C 48AWeF52XLBOI4RkLT24qb+NA3VLBpVstKDd6ry7LJii6TzEutg3F2Q8l0UmCqRhPwBx fHi7M/22y03TZMRee4w1ZOiuOPxnxBmCXKqEqQEqgYuhYlyp5eNFhAxR08fUKdvSwJ54 BSPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vg08kYWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v26si12448398ejr.748.2020.09.16.13.51.29; Wed, 16 Sep 2020 13:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vg08kYWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726739AbgIPUse (ORCPT + 99 others); Wed, 16 Sep 2020 16:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbgIPRBJ (ORCPT ); Wed, 16 Sep 2020 13:01:09 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CFFC0A3BFE; Wed, 16 Sep 2020 09:44:56 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id w5so7616117wrp.8; Wed, 16 Sep 2020 09:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6OX2minHfjzVyBOJQrdaqKGWzfqGpYJXESyQtwYpeWk=; b=vg08kYWwEgG9ogOjRr/AdZitt9N5LiQ10vULtfdvxOdX69uHN9II1K4DcctC6Eb2wQ T+NogkHfgFb45nSdjXp1AG61JthAH6C8Dbjqj3bZbClI98Amcr0HYjlJ/mi3psbBSsmX zuH9GDhzdQcQU30GiDImiqL4Z4/hyfvb6fU3k2tVQZPUVdF339jO3iV9PmrOwZT6J6rO bVBXmoFPLK14PIGdwz5ALriswLfb+QDTPfGf9zi7cMIUpkImIFtpmCt4kqHnCrv5r/Ts zP0X55D1uhehMrYj65lxPBgKxR2CLWlhxskNOMJEULSrJo0vu7116DwaLtPFwpvW7+so QZhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6OX2minHfjzVyBOJQrdaqKGWzfqGpYJXESyQtwYpeWk=; b=eJp3NiSP97KvCypGY8MTTJbHcGKpDabAMF+ISeLqoGaxDYdycP5qbqDrvce+ENxPzb ZgcyL1ndCQLE8I81ifIS60rbAVGiRtfg+buD3QWiWWLCumgVeRXsrir4DXgUd4XPAOiW EZI255nbQ0NcgF76te5p3RuZTwWPcSqIv/SFyMWpiwo4500lcXE0zge5i3z27X9/vn+O 6NqYUrpGasPfgMY6tINmjVYTRdYWjJvhc2XTjXBtzHHENhrU8WSDVbVbnyd6DAvdA/nc HMZq9Gjl5KtpVJhmGKhBvGa9pU43ZcxQOxwdsvzjQpbjk2zXuTHPyW2kjq8x1jNJOFR9 j/rg== X-Gm-Message-State: AOAM530pw2tzYAvuWuuu3qCIL8a1YK+QDA/xRJWeIX23tqxIbjv2zonw eS/huLsQuBAenM2HTMPcen4= X-Received: by 2002:adf:ff83:: with SMTP id j3mr28654393wrr.135.1600274695466; Wed, 16 Sep 2020 09:44:55 -0700 (PDT) Received: from lenovo-laptop (cpc83661-brig20-2-0-cust443.3-3.cable.virginm.net. [82.28.105.188]) by smtp.gmail.com with ESMTPSA id a13sm6326411wme.26.2020.09.16.09.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 09:44:54 -0700 (PDT) From: Alex Dewar X-Google-Original-From: Alex Dewar Date: Wed, 16 Sep 2020 17:44:52 +0100 To: Borislav Petkov Cc: Maxim Levitsky , Alex Dewar , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SVM: nSVM: fix resource leak on error path Message-ID: <20200916164452.5zg4bun3t6zdgpuc@lenovo-laptop> References: <20200914194557.10158-1-alex.dewar90@gmail.com> <922e825c090892f22d40a469fef229d62f40af5e.camel@redhat.com> <20200915091502.GE14436@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915091502.GE14436@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:15:02AM +0200, Borislav Petkov wrote: > On Tue, Sep 15, 2020 at 12:07:25PM +0300, Maxim Levitsky wrote: > > I think that this patch is based on unmerged patch, since I don't see > > any memory allocation in nested_svm_vmrun_msrpm, nor out_free label. > > in nether kvm/master, kvm/queue nor in upstream/master > > Paolo and I need to figure out first how to share the SEV-ES enablement > work and the other patches touching that file and then pile more fixes > ontop. Sorry for the noise! I didn't realise this was a work in progress -- Coverity picked it up. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette