Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 17:14:18 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] regmap: debugfs: Duplicate name string if delaying
 debugfs init
Message-ID: <20200916161418.GB6374@sirena.org.uk>
References: <20200916154433.7003-1-ckeepax@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="i0/AhcQY5QxfSsSZ"
Content-Disposition: inline
In-Reply-To: <20200916154433.7003-1-ckeepax@opensource.cirrus.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--i0/AhcQY5QxfSsSZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 16, 2020 at 04:44:33PM +0100, Charles Keepax wrote:

> -		node->name = name;
> +		node->name = kstrdup(name, GFP_KERNEL);
> +		if (!node->name) {

Two things here - one is that this should be kstrdup_const(), the other
is that we already took a copy of the name in __regmap_init() so the
thing to do here is to change the regmap_debugfs_init() call there to
use the copy we just made rather than the copy in the config.

--i0/AhcQY5QxfSsSZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9iOdkACgkQJNaLcl1U
h9CBfgf9GnSQpLoP4qudoLYN/FrsuHwdxt6zQlQIetYNPWVvc3qW4uLw73sq7YEc
EPqMamq2nd82vDJbtzEv7LqEoCd7OVwJn37OgBXjSNzW/l7TWuCx/Y4xNlYHYhS7
sRcStyG/jRrgM5xILP5Iw2AstYo6EFWmC+QE0BRW1VxicPwlA+3DDEi6keyiwZNB
KZp8u9Zh7+/w2VBuqDpyCmnnZ55OCxAZktEej6E2rsG9jWVhWDnLswFew3IzVlwL
zU993Z7kBGAv/o8osXHcbLTgRZh4dwmbB8L4s7zkhCepgY63APamWMgMb3EyewwN
JOKpnJk+4RzMNrmsr8csxtyO5EC/yQ==
=5+Pm
-----END PGP SIGNATURE-----

--i0/AhcQY5QxfSsSZ--