Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbWHANrE (ORCPT ); Tue, 1 Aug 2006 09:47:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751583AbWHANrD (ORCPT ); Tue, 1 Aug 2006 09:47:03 -0400 Received: from mail3.sea5.speakeasy.net ([69.17.117.5]:18054 "EHLO mail3.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S1751575AbWHANrC (ORCPT ); Tue, 1 Aug 2006 09:47:02 -0400 Date: Tue, 1 Aug 2006 09:46:58 -0400 (EDT) From: James Morris X-X-Sender: jmorris@d.namei To: Evgeniy Polyakov cc: lkml , David Miller , Ulrich Drepper , netdev , Zach Brown Subject: Re: [take2 1/4] kevent: core files. In-Reply-To: <11544248451203@2ka.mipt.ru> Message-ID: References: <11544248451203@2ka.mipt.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 562 Lines: 20 On Tue, 1 Aug 2006, Evgeniy Polyakov wrote: > + u->ready_num = 0; > +#ifdef CONFIG_KEVENT_USER_STAT > + u->wait_num = u->im_num = u->total = 0; > +#endif Generally, #ifdefs in the body of the kernel code are discouraged. Can you abstract these out as static inlines? - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/