Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp17209pxk; Wed, 16 Sep 2020 15:46:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT3r3jcgqj4OsDnKH3rOE4tZAceDpAraqt06lUpAvYnTdGzLHmASWFI5lXnWsfRNvgcAjJ X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr27346715ejj.17.1600296385298; Wed, 16 Sep 2020 15:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600296385; cv=none; d=google.com; s=arc-20160816; b=xmzCQ4/SZ699hBjTcNKZiINI3L71Fihr3eU2DR18mgmyGsiNoUnqJmr2XUKy4Jw1wC 824oCrJ4rb/vYnKR5SaZDdtERgrJuRNX62sITXSLJNIYVORyQoP0SJjKZdnwSkx+v35U TzwKECbzBVSoVIzr6VEE7aHkZvbnX9faF5lp53oPH9Pz77KDdBJV3q8BRpgv70ERcigw r/GeKofFW6L04uLx51vxoW80ta9s48pqVfRIUJCcNHdCQsc8UgXewxUWcpXriCHFXtxA bWxhIRvv3568SemQweZaz28gIiRppgKbSOqv6y4OpsRCrPq9cuqZOQD90zHfyTmTZFto QBlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:date:from:dkim-signature; bh=uaALsWfF1D9xfoXjRco36/wFZIs5nH3vP9iLlTuBzEI=; b=ftMM+zwjoAOXNI4NkIM65LEAyn1owwq7YwKNpHkLWrfzKMPCtZuxVSDc8HAmHTqc1X pvfgXtYnEsJd+95djT4zYGHZ2plJlRIKl8XNgZog6DoKCaull6wsv8ddB15i/ICrurtC PT1M0WzqYyH9asBbLajfvxGDbYmzXRRveZL3dVrweFZWeLgBHZo4dcTX5YTJhSU2zgRB F+AcBl+cbbBO8hmAN5fIL4SIHYgiQbVjXwlMDPfkWUFAbdfRpa/m1y3sUitxnVG/tAt6 qkCy7LdJzC6V28wgEyjWDnkGYDUE3iSaG8VYfJHKNIGaI0itd7kkt7oJa6j/JUp197oP WFSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IVzVtSCo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si2484261eja.565.2020.09.16.15.46.01; Wed, 16 Sep 2020 15:46:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=IVzVtSCo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbgIPWm6 (ORCPT + 99 others); Wed, 16 Sep 2020 18:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726322AbgIPWm5 (ORCPT ); Wed, 16 Sep 2020 18:42:57 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26227C061354; Wed, 16 Sep 2020 14:23:17 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id m6so8388590wrn.0; Wed, 16 Sep 2020 14:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uaALsWfF1D9xfoXjRco36/wFZIs5nH3vP9iLlTuBzEI=; b=IVzVtSCo5zE8dA/LZXtqUtUi0zKuFNGC+mJ5LvdUJS7FqoV3PfJBEnOoCwc6voQD8d u4fJYBAdu2skJ4IDhuqAWWiS/qN7qCVr4BZUzeocVw/Yxip385UxSN74cMUb1ZsWEfcw BcLPVu1EInwBAHC9UaQvDV6umf5EGtZYFaga4SQVGJnJyvzoVtrXF65FxxEPNgcAG3s2 mxBijNOHmlMQ/TNax2vaCnwxfwLLAvXhI+/50xajOlZ/mCaFGDEKkCoi5DBF+C4Xg+tX Klyu7DCO4cHfkmgHI2l40ia7tICoDXJ8QnOWeCdDgxQIKBjj/vq0MBMdBAEppvb9Z7aI 5J/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uaALsWfF1D9xfoXjRco36/wFZIs5nH3vP9iLlTuBzEI=; b=t7OUTr5l7B4CiisFZdgnmsgnrQ5sF5I4/bOd1iaKeKgt0DJC4plqfTG733DFOotvYa x8Zn+4RfqjLLI0WhqZQYZ2T0pAdVWMoQiSld9zA95FWxXQc3Kj23sRmnJBkLhysbrnDm OwO9UBHhm32WNsLYfYjbMYOtAVPW8W1mm/vpO6qPmZvrjomjFNO7S54lCnWfbDijpHSm cSFssUeP6rulNdW6YO4WQyN3PbhMKtGj8tQrNhEPl3UvaUW+qcKk7Usc0nTmU2CKX67g oWIFMrDzOjjwKQff2P2oIlTKDlJAUHWZFgNs6u8Sa1giK0lpBZKVZzlfU5ErjS6yViLL SYlg== X-Gm-Message-State: AOAM530Sza7oIGdMYHTJOHBlfpPIFbdlDVa3cEbbi5NoCVYY4rbn+IHR XzaWz4FJOo3EZUOugJTZbpk= X-Received: by 2002:a5d:6caf:: with SMTP id a15mr28884355wra.344.1600291395868; Wed, 16 Sep 2020 14:23:15 -0700 (PDT) Received: from lenovo-laptop (cpc83661-brig20-2-0-cust443.3-3.cable.virginm.net. [82.28.105.188]) by smtp.gmail.com with ESMTPSA id n10sm7743823wmk.7.2020.09.16.14.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 14:23:15 -0700 (PDT) From: Alex Dewar X-Google-Original-From: Alex Dewar Date: Wed, 16 Sep 2020 22:23:13 +0100 To: Alex Dewar Cc: Sean Wang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Russell King , Landen Chao , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: mt7530: Add some return-value checks Message-ID: <20200916212313.w727cxx5tzo2ttm7@lenovo-laptop> References: <20200916195017.34057-1-alex.dewar90@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916195017.34057-1-alex.dewar90@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 08:50:17PM +0100, Alex Dewar wrote: > In mt7531_cpu_port_config(), if the variable port is neither 5 nor 5, This should read "neither 5 nor 6", obviously. I'll fix in v2.