Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 16 Sep 2020 17:47:23 -0700 (PDT)
Message-Id: <20200916.174723.110340106752086972.davem@davemloft.net>
To:     matthias.schiffer@ew.tq-group.com
Cc:     woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        kuba@kernel.org, codrin.ciubotariu@microchip.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: ksz8795: really set the
 correct number of ports
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200916100839.843-1-matthias.schiffer@ew.tq-group.com>
References: <20200916100839.843-1-matthias.schiffer@ew.tq-group.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Date: Wed, 16 Sep 2020 12:08:39 +0200

> The KSZ9477 and KSZ8795 use the port_cnt field differently: For the
> KSZ9477, it includes the CPU port(s), while for the KSZ8795, it doesn't.
> 
> It would be a good cleanup to make the handling of both drivers match,
> but as a first step, fix the recently broken assignment of num_ports in
> the KSZ8795 driver (which completely broke probing, as the CPU port
> index was always failing the num_ports check).
> 
> Fixes: af199a1a9cb0 ("net: dsa: microchip: set the correct number of
> ports")

Please do not a tag into multiple lines.  Especially do not do this
with Fixes tags as people will do string matching on it.

> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

Applied and queued up for -stable.

Thanks.