Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbWHAOeq (ORCPT ); Tue, 1 Aug 2006 10:34:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932451AbWHAOep (ORCPT ); Tue, 1 Aug 2006 10:34:45 -0400 Received: from relay.2ka.mipt.ru ([194.85.82.65]:2508 "EHLO 2ka.mipt.ru") by vger.kernel.org with ESMTP id S932084AbWHAOeo (ORCPT ); Tue, 1 Aug 2006 10:34:44 -0400 Date: Tue, 1 Aug 2006 18:34:21 +0400 From: Evgeniy Polyakov To: James Morris Cc: lkml , David Miller , Ulrich Drepper , netdev , Zach Brown Subject: Re: [take2 1/4] kevent: core files. Message-ID: <20060801143421.GA14827@2ka.mipt.ru> References: <11544248451203@2ka.mipt.ru> <20060801135538.GA356@2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.7.5 (2ka.mipt.ru [0.0.0.0]); Tue, 01 Aug 2006 18:34:22 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 28 On Tue, Aug 01, 2006 at 10:27:36AM -0400, James Morris (jmorris@namei.org) wrote: > > > > + u->ready_num = 0; > > > > +#ifdef CONFIG_KEVENT_USER_STAT > > > > + u->wait_num = u->im_num = u->total = 0; > > > > +#endif > > > > > > Generally, #ifdefs in the body of the kernel code are discouraged. Can > > > you abstract these out as static inlines? > > > > Yes, it is possible. > > I would ask is it needed at all? > > Yes, please, it is standard kernel development practice. Will do. Thanks, James. > -- > James Morris > -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/