Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp55187pxk; Wed, 16 Sep 2020 18:43:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUuQLFaIKsSAvwL3pZTQSvBb2qJIdiEPBrk2KhtQmPs9vMiXAxPLAvQjN/Z0GKghAHyYg4 X-Received: by 2002:a17:906:556:: with SMTP id k22mr27734200eja.369.1600306982146; Wed, 16 Sep 2020 18:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600306982; cv=none; d=google.com; s=arc-20160816; b=p0h0sHG+YQoaCcf8ezsDePfqTaO7MU96ARRwlfbOs4gO6GdONVkdBKLW0S3/E1nZDH d+FR4CfllbrOJlmC6csZ6YSzHzO8GIjDgutOyTVB7eOBQBigjPzHXgFZv/oxOfkF4HHp 7WTWTzHMy/dWDPIq6SqgnTzrIzesk0PjlHE2k3N+kGWWeAStKSYwwI0W+8Vfrj7yAud3 +6s4uMgDBe13vSPaBc1WxBinlT7mWBQ9b7YTQQtYQH3eJoS+O3k+zFwz34lfZNXbD+4T YDqTtVsAESRDZGb2i/iaSplG6NaFYy1gprQ+xyPV92bs+hauyFSY4/cJeB5aoap/xG2c 3JgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GQbhGAXxUwF5C1lGvkKsB6CV1UN8QFSUOPAbXCLFBf8=; b=VWxnejRVva77ZGbJnpQcazZ2mcMMSKDLQV9G9JULNcI3uCZYNg8ZiI5393mm9vc1qw 7qjYU8Hs8wMDq+6yJyAUYvdw7w2CUE7sE6a33sMgZetktK1CUfslocXuxyTrMCUh04F0 OlUZy4bbX0vZkwtAV1x1Kc0agiFD4wcFS4ahX0PKZXG2U+7yiaN01DVroK+JulRXKytY C6G4unxbUsWMDGpkZbaH6pZb4ll9PfHfgiSDdNMhGCvhyhaxSljlIF3z8DrakvVJBqXm xKTUMsc8HhwGyFoWCK/Nw/1DXyT9z2SEASqVwPnq78M8z8+u3DlEPc4I1DB+YfVCOrtv OJXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jCFkelld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt8si12024721ejb.159.2020.09.16.18.42.37; Wed, 16 Sep 2020 18:43:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jCFkelld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726044AbgIQBlL (ORCPT + 99 others); Wed, 16 Sep 2020 21:41:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:58352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQBlI (ORCPT ); Wed, 16 Sep 2020 21:41:08 -0400 X-Greylist: delayed 325 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2020 21:41:07 EDT Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 951FF2076C; Thu, 17 Sep 2020 01:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600306862; bh=OrX6m8YxPdWu8LBOXGQR6nbtrtQ8xnzMdSfG0Bwlx8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jCFkelld6YgZXIe4JMpf7n7A8kOGwHqXO0M/BS9qU0gklNkpK/OMGUC6JrNNLSyUk j1vV2g9Tjgo+Z+Ixfq3dxoNZsbkCv3YFBDNDFV0wIt24KdbewLoQxA/rL/qjB1EC5L JEY9uDm8R/e35A6026FVqTGVC8RaPIac6jXijWNI= Date: Wed, 16 Sep 2020 21:41:01 -0400 From: Sasha Levin To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jonathan Cameron , Angelo Compagnucci Subject: Re: [PATCH 4.19 09/78] iio: adc: mcp3422: fix locking on error path Message-ID: <20200917014101.GH2431@sasha-vm> References: <20200915140633.552502750@linuxfoundation.org> <20200915140634.010489871@linuxfoundation.org> <20200916073100.GA32537@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200916073100.GA32537@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 09:31:00AM +0200, Pavel Machek wrote: >Hi! > >> [ Upstream commit a139ffa40f0c24b753838b8ef3dcf6ad10eb7854 ] >> >> Reading from the chip should be unlocked on error path else the lock >> could never being released. >> >> Fixes: 07914c84ba30 ("iio: adc: Add driver for Microchip MCP3422/3/4 high resolution ADC") >> Fixes: 3f1093d83d71 ("iio: adc: mcp3422: fix locking scope") > >Well, 3f1093d83d71 is only applied later in the stable series, so this >introduces spurious unlock. > >Ideally this should go just after 3f1093d83d71 ("iio: adc: mcp3422: >fix locking scope"). Patches rearranged, thanks! -- Thanks, Sasha