Date: Tue, 01 Aug 2006 23:44:22 +0900 (JST)
Message-Id: <20060801.234422.25910237.anemo@mba.ocn.ne.jp>
To: schwidefsky@googlemail.com
Cc: johnstul@us.ibm.com, akpm@osdl.org, zippel@linux-m68k.org,
       clameter@engr.sgi.com, linux-kernel@vger.kernel.org,
       ralf@linux-mips.org, ak@muc.de
Subject: Re: [PATCH] simplify update_times (avoid jiffies/jiffies_64
 aliasing problem)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <6e0cfd1d0607310336o355693a5l939db098b9210d81@mail.gmail.com>
References: <20060305.021542.126141997.anemo@mba.ocn.ne.jp>
	<20060730.235403.108306254.anemo@mba.ocn.ne.jp>
	<6e0cfd1d0607310336o355693a5l939db098b9210d81@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1218
Lines: 33

On Mon, 31 Jul 2006 12:36:38 +0200, "Martin Schwidefsky" <schwidefsky@googlemail.com> wrote:
> > --- a/arch/x86_64/kernel/time.c
> > +++ b/arch/x86_64/kernel/time.c
> > @@ -423,7 +423,8 @@ #endif
> >
> >         if (lost > 0) {
> >                 handle_lost_ticks(lost, regs);
> > -               jiffies += lost;
> > +               while (lost--)
> > +                       do_timer(regs);
> >         }
> >
> >  /*
> 
> I think that this is going into the wrong direction. There are a
> number of architectures that call do_timer(regs) in a while loop. It
> would be much nicer if do_timer would get the number of passed ticks
> as an argument. And the "regs" argument to do_timer is just useless.

But normally do_timer() is called just once, isn't it?  These loops
are just for lost ticks, which would be rarely happened.  So I think
tunning for usual case is better.

I agree that the "regs" argument is useless.  Another candidate for
cleanup.

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/