Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp81052pxk; Wed, 16 Sep 2020 19:36:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHTRfIJZvqCDqitBXe4L8snCrcwzcmVIJEr/bZ2aRxJOnXZVfIfxhQgyWx8xwlrShDjJuE X-Received: by 2002:a17:906:bcd5:: with SMTP id lw21mr28659543ejb.430.1600310186405; Wed, 16 Sep 2020 19:36:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600310186; cv=none; d=google.com; s=arc-20160816; b=Nj+VtjvwNilfe1mFhM81DxQox36tMspWBN6pr2PbuJMzlV5S+xXvmuuCDxQoIFS/Hq vTNz0IrDwojfyc2mLVGn9NXPzigmcQxBxg31rcUg7xRkFGEfFButGjpjAdKkl2hG9uln mYBp+gFvL9yTEDl2CESKeJCJMzpB2/2ClTCN2lw5CvKTBZ80Gnz3QWOVvI6i/aBAjcCx pAtA6SC+TLgWIrvfOfFNOhksrG4gWp9+LKa+J9hF15pxc5tFggdHsYsbIquMITs/FgbI /SJ1j3PRviS7GGcJQNEoMDUvHzR0njelSoa4NUR054mU+W9bCm06drhjkntT8J8/XMDP MtSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UMh2zjZi2urh+dyVn3Ppcopx/FNue09rKnN2uM18EnU=; b=BbgHAoBJ2WBj7kG2AKFjTUnE8hfZ5hNuVg/x3u2/wxQ8cJphMlIHNM7aWMBs4tDYll ftrz/fRlpPDGgosr30sCHUvuUSTyA2hzrcv6gw7XQhdQYob03FrJ4wE5Zj1Z7u56ii/s ZD9/Ub1csq+LKyqk6CYzzLFGL4Kj8Sw8pFTs68p8W/YE9m2Yc/lemQHdSzhQJKZcdtDP g+uT60wvlYPbNTQ1yyF3lFdz68INdD5247KkM2xWdcmCizJSpxMcdR4E1Qj6SAsMW0aO Wb/qbb9M3JRc1spMAIvf7gM9WWYCo+xNdO15Y0ndQDs9YyHcY44sSZfO/bbKihdlP7/3 Toiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bQpGQIUV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by20si3464913ejc.416.2020.09.16.19.36.02; Wed, 16 Sep 2020 19:36:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bQpGQIUV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgIQCd6 (ORCPT + 99 others); Wed, 16 Sep 2020 22:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbgIQCdE (ORCPT ); Wed, 16 Sep 2020 22:33:04 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7124AC06174A; Wed, 16 Sep 2020 19:25:27 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id j7so288796plk.11; Wed, 16 Sep 2020 19:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UMh2zjZi2urh+dyVn3Ppcopx/FNue09rKnN2uM18EnU=; b=bQpGQIUVmgGfuPpuci/amVAMFGggayq1pQHbH88QtDbCikoHa2bGA2CFoTPR7en7PP wRCdYevBMRIZsrDHBbzPR/4nuZryC4jIOsrohmRZlHw9NmON/5sXHRnWsMO2gLsa5oSN DohNZG2zNGYkRMGlV0fgi2nbEHsLVyUXCFi37mF+fMS5OndQ12HueflcVQal2DyXUqhs j7jLG/Mk/bpyVnNHRoHyOV+D5dcjJpq5UenUFSZlNG0xcRkUfXvvLbwBxKWgMpT+imsr j+cW/jlTwQumTyZ/0CEXhD/fM3gbshrUDchEMxRjDrjSadS0Y8mvzs+47JwSIJfL84yt Dtyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UMh2zjZi2urh+dyVn3Ppcopx/FNue09rKnN2uM18EnU=; b=Hj6RFpDd+qPEJsGcR2siKwrUMTJoqZGBkL/XzqiWv+2B3qZXCgkcQEi2Ay+2JoQ/EJ v/C4EFhWtWO5x/GHdm6eAb9on7ulwtiOKDY/pgjagTUPSpDaWIJy8jV0xEKTmhEXS4Ul OKm2iOzEhXTUdzuoCNunF7wf0q/g2CEINIBgr9b9t/rUmo/Inz73wm1QUuCgmZGUHQsQ zCIRLtN6e1mnAmmlvUg3qvHN89pv5chKUEL5Yzb75pRrSjNfqG6JQVJQkBOMLsZd2D+1 X9Ja7FDygNk6zujTEz5YugW52rYXPOCZSXGkHj06igpyXfw7HkAoYQfUX/q3RSxmWOcg tsPQ== X-Gm-Message-State: AOAM530VAcVFQ8vbN1/ZaxHb/bxq+wx2iYXrKJPBMR7NQ1uQyUnkvKEf HPi2L4FDgjjMyhRihUWpK+Nmh3dBYyAhucq0Cuw= X-Received: by 2002:a17:902:6ac6:b029:cf:85a7:8373 with SMTP id i6-20020a1709026ac6b02900cf85a78373mr26440053plt.2.1600309526746; Wed, 16 Sep 2020 19:25:26 -0700 (PDT) Received: from localhost.localdomain ([47.242.8.30]) by smtp.gmail.com with ESMTPSA id w203sm18286372pfc.97.2020.09.16.19.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 19:25:26 -0700 (PDT) From: Herrington To: Richard Cochran Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hankinsea@gmail.com Subject: [PATCH] ptp: mark symbols static where possible Date: Thu, 17 Sep 2020 10:25:08 +0800 Message-Id: <20200917022508.9732-1-hankinsea@gmail.com> X-Mailer: git-send-email 2.18.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmissing-prototypes] void pch_ch_control_write(struct pci_dev *pdev, u32 val) drivers/ptp/ptp_pch.c:201:5: warning: no previous prototype for ‘pch_ch_event_read’ [-Wmissing-prototypes] u32 pch_ch_event_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:212:6: warning: no previous prototype for ‘pch_ch_event_write’ [-Wmissing-prototypes] void pch_ch_event_write(struct pci_dev *pdev, u32 val) drivers/ptp/ptp_pch.c:220:5: warning: no previous prototype for ‘pch_src_uuid_lo_read’ [-Wmissing-prototypes] u32 pch_src_uuid_lo_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:231:5: warning: no previous prototype for ‘pch_src_uuid_hi_read’ [-Wmissing-prototypes] u32 pch_src_uuid_hi_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:242:5: warning: no previous prototype for ‘pch_rx_snap_read’ [-Wmissing-prototypes] u64 pch_rx_snap_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:259:5: warning: no previous prototype for ‘pch_tx_snap_read’ [-Wmissing-prototypes] u64 pch_tx_snap_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:300:5: warning: no previous prototype for ‘pch_set_station_address’ [-Wmissing-prototypes] int pch_set_station_address(u8 *addr, struct pci_dev *pdev) Signed-off-by: Herrington --- drivers/ptp/ptp_pch.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index ce10ecd41ba0..8db2d1893577 100644 --- a/drivers/ptp/ptp_pch.c +++ b/drivers/ptp/ptp_pch.c @@ -179,7 +179,7 @@ static inline void pch_block_reset(struct pch_dev *chip) iowrite32(val, (&chip->regs->control)); } -u32 pch_ch_control_read(struct pci_dev *pdev) +static u32 pch_ch_control_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u32 val; @@ -190,7 +190,7 @@ u32 pch_ch_control_read(struct pci_dev *pdev) } EXPORT_SYMBOL(pch_ch_control_read); -void pch_ch_control_write(struct pci_dev *pdev, u32 val) +static void pch_ch_control_write(struct pci_dev *pdev, u32 val) { struct pch_dev *chip = pci_get_drvdata(pdev); @@ -198,7 +198,7 @@ void pch_ch_control_write(struct pci_dev *pdev, u32 val) } EXPORT_SYMBOL(pch_ch_control_write); -u32 pch_ch_event_read(struct pci_dev *pdev) +static u32 pch_ch_event_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u32 val; @@ -209,7 +209,7 @@ u32 pch_ch_event_read(struct pci_dev *pdev) } EXPORT_SYMBOL(pch_ch_event_read); -void pch_ch_event_write(struct pci_dev *pdev, u32 val) +static void pch_ch_event_write(struct pci_dev *pdev, u32 val) { struct pch_dev *chip = pci_get_drvdata(pdev); @@ -217,7 +217,7 @@ void pch_ch_event_write(struct pci_dev *pdev, u32 val) } EXPORT_SYMBOL(pch_ch_event_write); -u32 pch_src_uuid_lo_read(struct pci_dev *pdev) +static u32 pch_src_uuid_lo_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u32 val; @@ -228,7 +228,7 @@ u32 pch_src_uuid_lo_read(struct pci_dev *pdev) } EXPORT_SYMBOL(pch_src_uuid_lo_read); -u32 pch_src_uuid_hi_read(struct pci_dev *pdev) +static u32 pch_src_uuid_hi_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u32 val; @@ -239,7 +239,7 @@ u32 pch_src_uuid_hi_read(struct pci_dev *pdev) } EXPORT_SYMBOL(pch_src_uuid_hi_read); -u64 pch_rx_snap_read(struct pci_dev *pdev) +static u64 pch_rx_snap_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u64 ns; @@ -256,7 +256,7 @@ u64 pch_rx_snap_read(struct pci_dev *pdev) } EXPORT_SYMBOL(pch_rx_snap_read); -u64 pch_tx_snap_read(struct pci_dev *pdev) +static u64 pch_tx_snap_read(struct pci_dev *pdev) { struct pch_dev *chip = pci_get_drvdata(pdev); u64 ns; @@ -297,7 +297,7 @@ static void pch_reset(struct pch_dev *chip) * traffic on the ethernet interface * @addr: dress which contain the column separated address to be used. */ -int pch_set_station_address(u8 *addr, struct pci_dev *pdev) +static int pch_set_station_address(u8 *addr, struct pci_dev *pdev) { s32 i; struct pch_dev *chip = pci_get_drvdata(pdev); -- 2.18.1