Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] hinic: fix potential resource leak
To:     "luobin (L)" <luobin9@huawei.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <huawei.libin@huawei.com>, <guohanjun@huawei.com>
References: <20200917030307.47195-1-liwei391@huawei.com>
 <dadc79e3-a923-7a4a-2d6f-3f33d614591e@huawei.com>
From:   "liwei (GF)" <liwei391@huawei.com>
Message-ID: <30debf33-49b9-3ac1-cf2a-4ee2c0f1f13d@huawei.com>
Date:   Thu, 17 Sep 2020 11:55:10 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.0
MIME-Version: 1.0
In-Reply-To: <dadc79e3-a923-7a4a-2d6f-3f33d614591e@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi luobin,

On 2020/9/17 11:44, luobin (L) wrote:
> On 2020/9/17 11:03, Wei Li wrote:
>> +	err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
>> +	if (err)
>> +		goto err_irq;
>> +
>> +	return 0;
>> +
>> +err_irq:
>> +	rx_del_napi(rxq);
>> +	return err;
> If irq_set_affinity_hint fails, irq should be freed as well.
> 
Yes, indeed.
I will fix that in the next spin.

Thanks,
Wei