Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Quan, Evan" <Evan.Quan@amd.com>
To:     Xiaoliang Pang <dawning.pang@gmail.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "Feng, Kenneth" <Kenneth.Feng@amd.com>,
        "zhengbin13@huawei.com" <zhengbin13@huawei.com>,
        "pelle@vangils.xyz" <pelle@vangils.xyz>,
        "yttao@amd.com" <yttao@amd.com>
CC:     "Das, Nirmoy" <Nirmoy.Das@amd.com>,
        "Huang, JinHuiEric" <JinHuiEric.Huang@amd.com>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tianjia.zhang@linux.alibaba.com" <tianjia.zhang@linux.alibaba.com>
Subject: RE: [PATCH v1] powerplay:hwmgr - modify the return value
Thread-Topic: [PATCH v1] powerplay:hwmgr - modify the return value
Thread-Index: AQHWjKUirneuuuI6L0uBp9h/EISx6KlsO/vg
Date:   Thu, 17 Sep 2020 04:26:20 +0000
Message-ID: <DM6PR12MB261972F93A745AD5BEF2B357E43E0@DM6PR12MB2619.namprd12.prod.outlook.com>
References: <20200917034610.21703-1-dawning.pang@gmail.com>
In-Reply-To: <20200917034610.21703-1-dawning.pang@gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=efcc980d-c30c-4674-8d87-ac157225a809;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=0;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal
 Use Only -
 Unrestricted;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-09-17T04:25:56Z;MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=amd.com;
x-originating-ip: [58.247.170.242]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 8e5e9d8c-f9fe-4774-c915-08d85ac1d435
x-ms-traffictypediagnostic: DM6PR12MB4337:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR12MB433756B78A9E3D0F4F032C7BE43E0@DM6PR12MB4337.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3276;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: qmiNRHZQza2GqEe0pVJ7pYm2aedtZETdkQNez+dMyS+pm8oko+lmPkYgcdIpU98YwbxuGKlH/4asWwjMI4G/PSttWWau9hNfYPvmaE2ea8rggbmcKz160xYhRPKK8Rocc37oDJKxKN792RPT4QH8isIeqDZT4exv3tNphPzbXDg6CiSJ2+9cBzdpGwN4OE7Q9N0AZAq9+VNT8+bd+UHKN6GnzPhtBi5X/nolAk7yx64UtJ6oaIZFsXNkTk3bduTakXu8EBger1KsECkUQIrAFYj5CHnmbuaou/fTFKmdlMhsyo2WiGuzusLa/Xm+rL/YShs4Q7Ma9cFuLjiUilAX3M5jjDK7rFSegIJTSIUcH2A9ecDcWyrNtPplaHOs9Nrr
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2619.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(6506007)(76116006)(110136005)(8936002)(478600001)(54906003)(4326008)(5660300002)(33656002)(8676002)(55016002)(52536014)(9686003)(66556008)(66946007)(71200400001)(2906002)(316002)(86362001)(66446008)(6636002)(66476007)(64756008)(83380400001)(7696005)(53546011)(186003)(26005)(921003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: a/K3e8KwW3zlTlHRsB7C1L8NM0l3zBEOuyvmt0YZ3M4N+O6nk/5nSTViiIugve0Nuibtl2chLJfJwpHn272k9pGC+urEVj/YEoFor4G/NrcpylR6s91Zh49lcWRM48Wzg7JJou2PFXQpNt9H3oEoMm1JQAYLhSjPtArV04OdPJ9pAhXB7YdJ79XfLHOUE0A5HNdY7DT114o1IroSA5d/BbcFPo3yYoCGJcLdB3cnypxa0yQpzopSweelHgBjrfDAkDxD0+7J73i5Ovwy0gUAQsm7Iabn7sbWlIDt9J6prfzGFKYjX1DTv0l7QFQS82g4BKY/57BTn4pX7qOGQknnRHdtZ9S1IPt1SYyllqz/S4fPmEWibJdMebgjD656hcQvlVZ1e8siXJEUmwLeaOxdsEqfJfvD8VbugVT6P0ILBdx86CsfVJjxhl1ubB1eknAIPqwKbsEf02r7ahJEKIeS4642BoIlRLbmEMgC5yq14G4gNHFV/kxy2Lit/1rJk4EJK06lSU7GWLJQjvk17fV32rvLIxzdkORdOKENxjmEozzNssQ3SX6RiyXMNTBTExXyqo+bI50WqhAGF1Tb8QvIzesN0JFbKEslhtlounb8hL/A+mVmv0v7EeSbo/i7TXXTuvy9VSYkICNkZAQUJYIO9A==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2619.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5e9d8c-f9fe-4774-c915-08d85ac1d435
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 04:26:20.6918
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LJ7uDJel4qaxATf9rLPAPS2o5xqwzbbIoVEAX/7AfH2s4Uylv32hjvsH73ZXtEXf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4337
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[AMD Official Use Only - Internal Distribution Only]

Thanks. Reviewed-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: Xiaoliang Pang <dawning.pang@gmail.com>
Sent: Thursday, September 17, 2020 11:46 AM
To: Quan, Evan <Evan.Quan@amd.com>; Deucher, Alexander <Alexander.Deucher@a=
md.com>; Koenig, Christian <Christian.Koenig@amd.com>; airlied@linux.ie; da=
niel@ffwll.ch; Feng, Kenneth <Kenneth.Feng@amd.com>; zhengbin13@huawei.com;=
 pelle@vangils.xyz; yttao@amd.com
Cc: Das, Nirmoy <Nirmoy.Das@amd.com>; Huang, JinHuiEric <JinHuiEric.Huang@a=
md.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; li=
nux-kernel@vger.kernel.org; tianjia.zhang@linux.alibaba.com; dawning.pang@g=
mail.com
Subject: [PATCH v1] powerplay:hwmgr - modify the return value

modify the return value is -EINVAL

Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (v5)"=
)
Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)=
")
Cc: Eric Huang <JinHuiEric.Huang@amd.com>
Cc: Evan Quan <evan.quan@amd.com>
Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
 drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/g=
pu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index c378a000c934..7eada3098ffc 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -4659,7 +4659,7 @@ static int vega10_display_configuration_changed_task(=
struct pp_hwmgr *hwmgr)
 if ((data->water_marks_bitmap & WaterMarksExist) &&
 !(data->water_marks_bitmap & WaterMarksLoaded)) {
 result =3D smum_smc_table_manager(hwmgr, (uint8_t *)wm_table, WMTABLE, fal=
se);
-PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);
+PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);
 data->water_marks_bitmap |=3D WaterMarksLoaded;
 }

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/g=
pu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
index a678a67f1c0d..04da52cea824 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
@@ -2390,7 +2390,7 @@ static int vega12_display_configuration_changed_task(=
struct pp_hwmgr *hwmgr)
 !(data->water_marks_bitmap & WaterMarksLoaded)) {
 result =3D smum_smc_table_manager(hwmgr,
 (uint8_t *)wm_table, TABLE_WATERMARKS, false);
-PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);
+PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);
 data->water_marks_bitmap |=3D WaterMarksLoaded;
 }

--
2.17.1