Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200917031414.47498-1-liwei391@huawei.com>
In-Reply-To: <20200917031414.47498-1-liwei391@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Thu, 17 Sep 2020 14:23:07 +0900
Message-ID: <CAM9d7cicKypGwhASKfu8GKE0y4v80o9tEyv7tn1d14J2tOezzw@mail.gmail.com>
Subject: Re: [PATCH] Revert "perf report: Treat an argument as a symbol filter"
To:     Wei Li <liwei391@huawei.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Li Bin <huawei.libin@huawei.com>, guohanjun@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 17, 2020 at 12:15 PM Wei Li <liwei391@huawei.com> wrote:
>
> Since commit 6db6127c4dad ("perf report: Treat an argument as a symbol
> filter"), the only one unrecognized argument for perf-report is treated
> as a symbol filter. This is not described in man page nor help info,
> and the result is really confusing, especially when it's misspecified by
> the user (e.g. missing -i for perf.data).

How about adding documentation then?

Thanks
Namhyung

>
> As we can use "--symbol-filter=" if we really want to filter a symbol,
> it may be better to revert this misfeature.
>
> Signed-off-by: Wei Li <liwei391@huawei.com>
> ---
>  tools/perf/builtin-report.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 3c74c9c0f3c3..f57ebc1bcd20 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1317,13 +1317,9 @@ int cmd_report(int argc, const char **argv)
>         argc = parse_options(argc, argv, options, report_usage, 0);
>         if (argc) {
>                 /*
> -                * Special case: if there's an argument left then assume that
> -                * it's a symbol filter:
> +                * Any (unrecognized) arguments left?
>                  */
> -               if (argc > 1)
> -                       usage_with_options(report_usage, options);
> -
> -               report.symbol_filter_str = argv[0];
> +               usage_with_options(report_usage, options);
>         }
>
>         if (annotate_check_args(&report.annotation_opts) < 0)
> --
> 2.17.1
>