Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error
 value
To:     Xiaoliang Pang <dawning.pang@gmail.com>, mchehab@kernel.org,
        sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org
Cc:     alexander.deucher@amd.com, evan.quan@amd.com,
        christian.koenig@amd.com, linux-media@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20200917034451.20897-1-dawning.pang@gmail.com>
From:   Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-ID: <75262d3f-eeb6-5531-a93d-85376236774a@linux.alibaba.com>
Date:   Thu, 17 Sep 2020 13:31:13 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200917034451.20897-1-dawning.pang@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

LGTM.

Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

On 9/17/20 11:44 AM, Xiaoliang Pang wrote:
> modify the return error value is -EDOM
> 
> Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
> Cc: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
> ---
>   .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c  | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> index fdca743c4ab7..424e7a15a389 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> @@ -44,7 +44,7 @@ int ia_css_queue_load(
>   				   the value as zero. This causes division by 0
>   				   exception as the size is used in a modular
>   				   division operation. */
> -				return EDOM;
> +				return -EDOM;
>   			}
>   		}
>   
>