Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static
To:     YueHaibing <yuehaibing@huawei.com>, clm@fb.com,
        josef@toxicpanda.com, dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200916142604.37744-1-yuehaibing@huawei.com>
From:   Anand Jain <anand.jain@oracle.com>
Message-ID: <9d4c2521-338a-8bce-46a7-b48818ddad66@oracle.com>
Date:   Thu, 17 Sep 2020 09:47:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200916142604.37744-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 16/9/20 10:26 pm, YueHaibing wrote:
> Fix sparse warning:
> 
> fs/btrfs/sysfs.c:1386:5: warning:
>   symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?


  misc-next branch has it declared static. It was fixed later.

Thanks, Anand


> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   fs/btrfs/sysfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index e7b0e10685d9..279d9262b676 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
>   	return ret;
>   }
>   
> -int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> +static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
>   {
>   	int ret;
>   	struct btrfs_device *device;
>