Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <4865efd5e746d2e94cc4680a47a30a0d@codeaurora.org>
References: <1599536645-4593-1-git-send-email-mansur@codeaurora.org> <159959010893.454335.18221321331314189759@swboyd.mtv.corp.google.com> <4865efd5e746d2e94cc4680a47a30a0d@codeaurora.org>
Subject: Re: [PATCH 1/2] venus: core: change clk enable and disable order in resume and suspend
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     linux-media@vger.kernel.org, stanimir.varbanov@linaro.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org
To:     mansur@codeaurora.org
Date:   Thu, 17 Sep 2020 00:18:31 -0700
Message-ID: <160032711157.4188128.1711388061841789272@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting mansur@codeaurora.org (2020-09-16 18:07:44)
> > On 2020-09-09 00:05, Stephen Boyd wrote:
> >> Quoting Mansur Alisha Shaik (2020-09-07 20:44:05)
> >>> Currently video driver is voting after clk enable and un voting
> >>> before clk disable. Basically we should vote before clk enable
> >>> and un vote after clk disable.
> >>>=20
> >>> Corrected this by changing the order of clk enable and clk disable.
> >>>=20
> >>> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> >>> ---
> >>=20
> >> Any Fixes: tag?
> Added Fixes tag
> >>=20
> >>>  drivers/media/platform/qcom/venus/core.c | 17 ++++++++++-------
> >>>  1 file changed, 10 insertions(+), 7 deletions(-)
> >>>=20
> >>> diff --git a/drivers/media/platform/qcom/venus/core.c=20
> >>> b/drivers/media/platform/qcom/venus/core.c
> >>> index c5af428..4857bbd 100644
> >>> --- a/drivers/media/platform/qcom/venus/core.c
> >>> +++ b/drivers/media/platform/qcom/venus/core.c
> >>> @@ -363,13 +363,16 @@ static __maybe_unused int=20
> >>> venus_runtime_suspend(struct device *dev)
> >>>         if (ret)
> >>>                 return ret;
> >>>=20
> >>> +       if (pm_ops->core_power) {
> >>> +               ret =3D pm_ops->core_power(dev, POWER_OFF);
> >>> +               if (ret)
> >>> +                       return ret;
> >>> +       }
> >>> +
> >>>         ret =3D icc_set_bw(core->cpucfg_path, 0, 0);
> >>>         if (ret)
> >>>                 return ret;
> >>=20
> >> Shouldn't we power it back up if this fails during suspend?
> On icc_set_bw() failure, we are just power it and return.
> Addressed these comments and posted new version
> https://lore.kernel.org/patchwork/project/lkml/list/?series=3D463224

Thanks. It's customary to Cc reviewers on patches, so please add me on
the next round of patches.