Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1600305963-7659-5-git-send-email-mansur@codeaurora.org>
References: <1600305963-7659-1-git-send-email-mansur@codeaurora.org> <1600305963-7659-5-git-send-email-mansur@codeaurora.org>
Subject: Re: [RESEND v2 4/4] venus: put dummy vote on video-mem path after last session release
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org,
        Mansur Alisha Shaik <mansur@codeaurora.org>
To:     Mansur Alisha Shaik <mansur@codeaurora.org>,
        linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Date:   Thu, 17 Sep 2020 00:26:27 -0700
Message-ID: <160032758702.4188128.5484979798760048057@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Mansur Alisha Shaik (2020-09-16 18:26:03)
> As per current implementation, we are unvoting "videom-mem" path
> for last video session during vdec_session_release().
> While video playback when we try to suspend device, we see video clock
> warnings since votes are already removed during vdec_session_release().
>=20
> corrected this by putting dummy vote on "video-mem" after last video
> session release and unvoting it during suspend.
>=20
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---

Fixes tag? Should this be combined with an earlier change?

>  drivers/media/platform/qcom/venus/pm_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/med=
ia/platform/qcom/venus/pm_helpers.c
> index 57877ea..c0a3524 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -212,6 +212,9 @@ static int load_scale_bw(struct venus_core *core)
>         }
>         mutex_unlock(&core->lock);
> =20
> +       if (!total_avg && !total_peak)
> +               total_avg =3D kbps_to_icc(1000);

Can you add a comment in the code here? Just guessing but something
like..

	/*
	 * Keep bandwidth enabled here so that vdec_session_release()
	 * can disable clks without clks getting stuck. We'll drop the
	 * bandwidth request when this device is suspended so this is a
	 * low value to keep things on but not high power until the
	 * device is powered down.
	 */

> +
>         dev_dbg(core->dev, VDBGL "total: avg_bw: %u, peak_bw: %u\n",
>                 total_avg, total_peak);
>