Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp243968pxk; Thu, 17 Sep 2020 01:37:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOV+Q4wt4KIhgLAFr987QbIyWjp4xVUgcy0UxjGccIJ/W+bI4G8JoUDHOSgaHM93pWuIjq X-Received: by 2002:a05:6402:1773:: with SMTP id da19mr30656302edb.171.1600331878774; Thu, 17 Sep 2020 01:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600331878; cv=none; d=google.com; s=arc-20160816; b=LeJD4CZHY8PYreZhhk2Z57WKNLzPX5d76+J5lYKICbwwL094BdgtcGDJcaQIjnrKJJ QS+ZF4DnSHggwMIi+Kt9BgiB/WUwUuqow2InZ10kc41pFamFLGUKqaT96OJqCh0cdsga TTVaS+liX2SoFN971z1jqhlwnt0FLzVG9fSkFORR0DwMgWV5eulVsnr2exGYs3pqp45/ 4J2y+Qq+x3Cer0a9/Dtsk+ri49GfmUCeIjypHdgSLBMZ7byMYHagcT7cYIxz03LBRagc DFVVdW6j1ok4W4ijoU2J17SLXdeWtrkPCj58qEWhKUZ12XxqHma+HZcsQ7sEhMOfcHku cmqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=gtGu9UUsd//x7NyTheFLNifE/O+n3VvopAXmwSrwqbM=; b=i/TNicEk84FDAUQgQyHynxdZkAgrF8iuZKaHWxlL4AFZ/aZ4u0fjJRptr5yqgP8Jo0 eX1EEJg7LPwpW+UL+tuHq3ieuYxG4KVTphQQXpDm9dEddff+5KWTXAtRY5Hc2ZYM5n4Y D925eMKd9ipYJFYxtbWr/F0176cEXRaMDxg6pc73pZ82DdQ4ldO5Xz7h3PyL7nBtwZts J1TAEKDj1ljAQ0MsyEAzGOsv6XrjvLL9hst9OW4j/cqWatQ68ksbvH8fSa0jAiqA7QdO mz57bKDS4wfinACgrBb/Ra/oS2mOKHj7xMwsBiA4NF4Hl7pCZ+t1/1cl+6ithEm8Yavs nFqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=iGivtR7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l23si14298931ejb.172.2020.09.17.01.37.34; Thu, 17 Sep 2020 01:37:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=iGivtR7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgIQIgb (ORCPT + 99 others); Thu, 17 Sep 2020 04:36:31 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3474 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbgIQIg2 (ORCPT ); Thu, 17 Sep 2020 04:36:28 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 17 Sep 2020 01:36:13 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 17 Sep 2020 01:36:26 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 17 Sep 2020 01:36:26 -0700 Received: from [10.26.74.242] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep 2020 08:36:23 +0000 Subject: Re: [Patch 1/2] cpufreq: tegra194: get consistent cpuinfo_cur_freq To: Sumit Gupta , , , , , , , CC: , References: <1600276277-7290-1-git-send-email-sumitg@nvidia.com> <1600276277-7290-2-git-send-email-sumitg@nvidia.com> From: Jon Hunter Message-ID: <81d2517d-6581-b491-c509-832fd1c0321e@nvidia.com> Date: Thu, 17 Sep 2020 09:36:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1600276277-7290-2-git-send-email-sumitg@nvidia.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600331773; bh=gtGu9UUsd//x7NyTheFLNifE/O+n3VvopAXmwSrwqbM=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=iGivtR7ZwTdYMlg8h794S9mC5vPM3vQlLlftl3mo5bKRbxp7IqdTcW0q0N6AJIvJX CZKARUptLgKBFmlySS9fTJCLezQxnSSSRaXc5BGjePPRMYyCdTTeS/oKMy/zo6KV+w nDtMzVR/rRCDxaO7kCEaDo5/AoGZU3cuihyrIqbRniIAOi9k6sn3ZJh/yMJxacuvL9 jF+FQmvsfEwBhHsuJhz5SFoulhVJYXbGkzhwIOkbqP0x4BfeKFGS6/3uz54n0z+x15 ciyXj2dm3zPtRWKun+h5bnZsPLnWWMgb0IHayhJfVDm31eFpO9fgAysDj33mHlDWSr oCp1yQEaHQ6ag== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2020 18:11, Sumit Gupta wrote: > Frequency returned by 'cpuinfo_cur_freq' using counters is not fixed > and keeps changing slightly. This change returns a consistent value > from freq_table. If the reconstructed frequency has acceptable delta > from the last written value, then return the frequency corresponding > to the last written ndiv value from freq_table. Otherwise, print a > warning and return the reconstructed freq. We should include the Fixes tag here ... Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") > > Signed-off-by: Sumit Gupta Otherwise ... Reviewed-by: Jon Hunter Tested-by: Jon Hunter Viresh, ideally we need to include this fix for v5.9. Do you need Sumit to resend with the Fixes tag or are you happy to add? Thanks Jon -- nvpublic