Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp259869pxk;
        Thu, 17 Sep 2020 02:12:33 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzR1gCuDF02ws0klg9uh/oaUnB1J2wAjvAh+ZWw8Lraj+hfFjf5w6DAX9aPv6G+p2GMk7Ky
X-Received: by 2002:a17:906:850e:: with SMTP id i14mr29288435ejx.168.1600333952850;
        Thu, 17 Sep 2020 02:12:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600333952; cv=none;
        d=google.com; s=arc-20160816;
        b=ZjdheMQXhyMmr0xJPxLQoaa0olr1ifSMBJg8iSXv8JGkr30tEBOxRQaFmCoioaTEwQ
         Uf8+tM7F7HaiM6tltIw3wWU5Uag4AvMM3YVK/o5ukjZozSbArwOCnx2vd6q8X1PfRHvR
         QhhP2DPCGAH3VDGxdzKTZH1ev+2zkhoh9AkOzuIWIyUAc3+LDj6pfGTjpyY/7IoiEnnE
         nCbNkrbK2GDlR1Zk7Ds7MxQ+Mm1+lWnICPY5BAJjv/ol7gQ0B1D4OCImm/lvtb64oAa+
         3EV4HhilefJ8nQB7l9jeud/yW6HG3LtHKPFschl6vxkvKWOQUeunam1QZs7cWDVmUzEr
         ctYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=mnh+2hfEbHi6YA77yln4HeXzAzNL58Y3B6oR5K7Jkn0=;
        b=P3DygzcvYfS37SQgtmYQRtWor+E/gP8pPuTgr5feBPICMJQEIAPoCynhRZH6rSDO1K
         pR3r7UJ4Qy0ApU9TqvLP/Y3G18cqeF9CIKmPc+gfHiHLN0byByPlDozmE8wTVL09fZZu
         EiVTBgcNgERPoZz8uk72d1zRswYIbAeELD6pdKJvRvckk8XcRPhd52O2FzMEa+Vh6yQM
         54qf0o2s8BgU3XQvy4e6x95lMsZ1maD5doIVuUfvEPl61/aA6iw/TLDwCwh4DtFZa3bB
         NWV6INz8+bddmIZJ7YfF+Fcm09UJ4PZ0HRTm0iyVmC8pNnGSb/gZqkPxchSkkKRxzKZk
         JITg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="F4mbesU/";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g12si8042348edn.403.2020.09.17.02.12.09;
        Thu, 17 Sep 2020 02:12:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="F4mbesU/";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726446AbgIQJJb (ORCPT <rfc822;shmalave.kernel@gmail.com>
        + 99 others); Thu, 17 Sep 2020 05:09:31 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:8662 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726171AbgIQJJb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 17 Sep 2020 05:09:31 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f63279c0002>; Thu, 17 Sep 2020 02:08:44 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 17 Sep 2020 02:09:27 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 17 Sep 2020 02:09:27 -0700
Received: from [10.26.74.242] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 17 Sep
 2020 09:09:17 +0000
Subject: Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard
 interrupts
To:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Marc Zyngier <maz@kernel.org>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "Sumit Garg" <sumit.garg@linaro.org>, <kernel-team@android.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Russell King <linux@arm.linux.org.uk>,
        Jason Cooper <jason@lakedaemon.net>,
        Saravana Kannan <saravanak@google.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Gregory Clement" <gregory.clement@bootlin.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        "Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <will@kernel.org>,
        Valentin Schneider <Valentin.Schneider@arm.com>,
        linux-tegra <linux-tegra@vger.kernel.org>
References: <20200901144324.1071694-1-maz@kernel.org>
 <20200901144324.1071694-9-maz@kernel.org>
 <CGME20200914130601eucas1p23ce276d168dee37909b22c75499e68da@eucas1p2.samsung.com>
 <a917082d-4bfd-a6fd-db88-36e75f5f5921@samsung.com>
 <933bc43e-3cd7-10ec-b9ec-58afaa619fb7@nvidia.com>
 <3378cd07b92e87a24f1db75f708424ee@kernel.org>
 <CACRpkdYvqQUJaReD1yNTwiHhaZpQ9h5Z9DgdqbKkCexnM7cWNw@mail.gmail.com>
 <049d62ac7de32590cb170714b47fb87d@kernel.org>
 <a88528cd-eb76-367a-77d6-7ae20bd28304@nvidia.com>
 <81cb16323baa1c81e7bc1e8156fa47b8@kernel.org>
 <e317b2fe-52e3-8ce7-ba77-43d2708d660f@nvidia.com>
 <4645f636-e7cc-6983-a3b7-897c20ec5096@samsung.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <bec733a1-227f-d943-90dd-85fc9a993109@nvidia.com>
Date:   Thu, 17 Sep 2020 10:09:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4645f636-e7cc-6983-a3b7-897c20ec5096@samsung.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1600333724; bh=mnh+2hfEbHi6YA77yln4HeXzAzNL58Y3B6oR5K7Jkn0=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=F4mbesU/lx+WOj0v9InZSi8Qdgos5F7v59koJlfx85AxYkozo7GWTfPEpXc7gyUmj
         t762hIU7FWKp+rStnubQuDvbr/WVdvTII5lBO901Po4CXZvvrTDIirgffmxrYpDUvl
         bN3BN+sEJ8TcNU904PL04BTtBWZU2Knwr/1HrWfpwv0NmO5g1zItN3oBOYDS8rqrR5
         DaU5vwFQs/Cj4U8THmPcXZH9lGhBbXqXk5Z22MqNoXpV6bh+dh0+rNMZH3E7bj1AMn
         DyjqtT9yaCzO1IYmx+RP4vhBZ/6Kuwfz+Z8e4qSpQQUTZdhWafzeu70mEkKS6dIlQk
         JkV18Q/BI3hhQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/09/2020 09:54, Marek Szyprowski wrote:
> Hi Jon,
>=20
> On 17.09.2020 10:49, Jon Hunter wrote:
>> On 17/09/2020 09:45, Marc Zyngier wrote:
>>> On 2020-09-17 08:54, Jon Hunter wrote:
>>>> On 17/09/2020 08:50, Marc Zyngier wrote:
>>>>> On 2020-09-17 08:40, Linus Walleij wrote:
>>>>>> On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier <maz@kernel.org> wrote:
>>>>>>
>>>>>>> Can you try the patch below and let me know?
>>>>>> I tried this patch and now Ux500 WORKS. So this patch is definitely
>>>>>> something you should apply.
>>>>>>
>>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (is_f=
rankengic())
>>>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_sgi_intid(irqstat);
>>>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 this_cpu=
_write(sgi_intid, intid);
>>>>>> This needs changing to irqstat to compile as pointed out by Jon.
>>>>>>
>>>>>> With that:
>>>>>> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>>>>> Thanks a lot for that.
>>>>>
>>>>> Still need to understand why some of Jon's systems are left unbootabl=
e,
>>>>> despite having similar GIC implementations (Tegra194 and Tegra210 use
>>>>> the same GIC-400, and yet only one of the two boots correctly...).
>>>> So far, I have only tested this patch on Tegra20. Let me try the other
>>>> failing boards this morning and see if those still fail.
>>> Tegra20 (if I remember well) is a dual A9 with the same GIC implementat=
ion
>>> as Ux500, hence requiring the source CPU bits to be written back. So th=
is
>>> patch should have cured it, but didn't...
>>>
>>> /me puzzled.
>> Me too. Maybe there just happens to be something else also going wrong
>> in next. I am doing a bit more testing to see if applying the fix
>> directly on top of this change fixes it to try and eliminate anything
>> else in -next.
>>
>> Linus, what -next are you testing on? I am using next-20200916.
>=20
> next-20200916 completely broken on ARM and ARM64. Please check=20
> next-20200915 + the mentioned fix or just check=20
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log=
/?h=3Dirq/ipi-as-irq

Ah thanks! Any idea what is causing the other failure on next-20200916?

Yes we have noticed that now everything fails next-20200916 so not just
this issue.

Cheers
Jon

--=20
nvpublic