Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp273523pxk; Thu, 17 Sep 2020 02:42:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTDpHs3reCMsw9chTaDg/HGjBV5YFul9M5D+dKsKT9KGUH98LF1/qjE4zb1T/kI+MOkGPz X-Received: by 2002:a05:6402:1593:: with SMTP id c19mr32176778edv.33.1600335762810; Thu, 17 Sep 2020 02:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600335762; cv=none; d=google.com; s=arc-20160816; b=aY/mxYnC3HC0CdoqQRoST0WUeJuec0W8tQAJIRT4dna8rpfYxOYvaNYqLbSZGdxrG2 VL3YLt6HixODh2O5C7KMNaiuZuEC8jx9XsSP/F42QNql5/+7UUtAvLgow5Y0RlmO+v+D aDVfnZIkTT8hmlBDLUp8vwgaot52/Nb3DsV43yz5SYvVs4JHxarWBMdUcBrTyDbhFqHP GSGNpOhDFOJZYNcBSx5fkX3T9KboEVpuQnXJq0TtaqW/nuI9Gvva7uptr7NmQIwdpZPl Z8ogIKUBRBz4srduVdAjnTcOdnBQe+G02PT9u8fvOHdOxBfqswU6FnrNM/Rd4/MVkwHk bvlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gSRn4R+wsZrRg7X+q05/zOo+dEqKEeyKAGD5yN2Wvyw=; b=jeDv7Rlhdja+TCP6kCcp5ovIBZAHvFi8N0gINCOS4v7QZwSZY/YoNg/l4eQzkNy6jQ 45pKYK8fYhaKU+qUj+f53LyhOnHZBnxyYo/vilP0SDMyYG2igZD2eZ3MUHNEOaFGe/0g t7XGpoqEILLL5XjlfLfTzfRZZKWITTQiY57D8aoiEasgZLNapAr0bFjEWV6JVyjJeg12 Jaz756ILpKoH1Tg5LJeixhaAMqemCGvF4MiC97qHZ9Qkz44mkIOFdtmhL3MJXomg7WKT 1iQl5depc0S+iT3F11DPx/ox5ryq8r6HKG3KlPoaekj0EuEi6tA/dvTRuT9ds0a30c4f dvfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=IaeDatMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a18si14122282edy.407.2020.09.17.02.42.19; Thu, 17 Sep 2020 02:42:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=IaeDatMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbgIQJlE (ORCPT + 99 others); Thu, 17 Sep 2020 05:41:04 -0400 Received: from mail.skyhub.de ([5.9.137.197]:54578 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgIQJlE (ORCPT ); Thu, 17 Sep 2020 05:41:04 -0400 Received: from zn.tnic (p200300ec2f1053000730ae91ea344e59.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:5300:730:ae91:ea34:4e59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 29B441EC032C; Thu, 17 Sep 2020 11:41:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1600335662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=gSRn4R+wsZrRg7X+q05/zOo+dEqKEeyKAGD5yN2Wvyw=; b=IaeDatMSe+U4UkaBNx4hd+Tv+6elqn59PZgTfmavwQQ28/3FCxcHa685ADgPUvjpKT5oPn +hZUJBAnG/MUfZw5PQSuqVPVEVwP9eamUQ82b/PB5tyK1+Sl50R7DEfdTE0c8raLBodD73 lR3q5YYMnm33Oi1/gnLhO0JWfWWIoqY= Date: Thu, 17 Sep 2020 11:40:55 +0200 From: Borislav Petkov To: Arvind Sankar Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/cmdline: Disable instrumentation of cmdline unconditionally Message-ID: <20200917094055.GF31960@zn.tnic> References: <20200906154637.1618112-1-nivedita@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200906154637.1618112-1-nivedita@alum.mit.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 06, 2020 at 11:46:37AM -0400, Arvind Sankar wrote: > On 32-bit, cmdline_find_option_bool() is used before paging is enabled, > from check_loader_disabled_bsp() in the early microcode loader. > Instrumentation options that insert accesses to global data will likely > crash or corrupt memory at this point. What is the use case here, can you trigger an actual crash? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette