Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 10:40:54 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     akpm@linux-foundation.org, alex.bou9@gmail.com,
        gustavoars@kernel.org, ira.weiny@intel.com, jrdr.linux@gmail.com,
        linux-kernel@vger.kernel.org, madhuparnabhowmik10@gmail.com,
        mporter@kernel.crashing.org, willy@infradead.org
Subject: Re: [PATCH] mm/gup: protect unpin_user_pages() against npages==-ERRNO
Message-ID: <20200917074054.GO18329@kadam>
References: <20200916100232.GF18329@kadam>
 <20200917065706.409079-1-jhubbard@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200917065706.409079-1-jhubbard@nvidia.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Sep 16, 2020 at 11:57:06PM -0700, John Hubbard wrote:
> As suggested by Dan Carpenter, fortify unpin_user_pages() just a bit,
> against a typical caller mistake: check if the npages arg is really a
> -ERRNO value, which would blow up the unpinning loop: WARN and return.
> 
> If this new WARN_ON() fires, then the system *might* be leaking pages
> (by leaving them pinned), but probably not. More likely, gup/pup
> returned a hard -ERRNO error to the caller, who erroneously passed it
> here.
> 
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Souptick Joarder <jrdr.linux@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> 
> Hi Dan,
> 
> Is is OK to use your signed-off-by here? Since you came up with this.
> 

Yeah.  That's fine.

regards,
dan carpenter