Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp286025pxk; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwV4AMi0IXkz/ZVz9j3KX3nMstbJ/Y60sxtpjs1xuZ16MzGwTOTYak/xdPNRLNj1j8uF15T X-Received: by 2002:a17:906:d78c:: with SMTP id pj12mr29393874ejb.36.1600337172404; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600337172; cv=none; d=google.com; s=arc-20160816; b=LmcjKRiHmZ8LLrIMEUeQTdDQUbs4ZdcWiC0o3iWmmtzyc4HEPP5PgYzAL36LNPqNih tbNiO6HDJtr15aCvpGwVuzjYTA5lcgDUElfDbvKycxYf0aqJC9H87LkBMPlVLYGNnYhQ Lc+mqT61Avu+ZgPrnYeowowGo6vQwtD9qNtm53gU5/yd1pxG3b1ljmO6kkm8wjNa99EM 7w2kS/Ar9T7v6OcdHaT9FHKvix+W5l9Basc8zzb730iyjbghYcwieeydkus4WCYHFsu+ OiKbGsfzsHBobUh63AKGKAgGFdax/dKV957wA6I2hH2Fxbs0OaH+Zi20UGWdzTaPTwXN rvbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=7nS6u/Dtr11MlGSNYKLuAmUjvF1cQFEYuqHEh+4YYFY=; b=MenuYDmcwgPU4i+uyKo7LekfIa2MS3DfO4MYp31BbQLE/EsOU0iqL22Kn+PQuKmRYJ pEK/Vw2gDRnIJ6iIh7K19fLoRcbf83q87HNoGoBehG3l9g2+C9d/72cP/5xj/bG9Epgz YLqjn6kh3VxNNt31mn/bX7tB2fqglDnEwQfgdZK366IYClTrVWKW4ZUmCywRb8W/edUz 0fApFaO27lRdJf65yC5B8qvFlf9Rxz61vExQ3WpcFHoFfwrz7ov9R5L9cNuDYxqAUH/R SMXSQVtQWc7k3ENG4G2urgX1yy0qk41O0Uy9zXupujreWMtLu2BvDuDh5LAHExQqxbiO jHBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v9si13929944eds.46.2020.09.17.03.05.49; Thu, 17 Sep 2020 03:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbgIQKCo (ORCPT + 99 others); Thu, 17 Sep 2020 06:02:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:32026 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgIQKCl (ORCPT ); Thu, 17 Sep 2020 06:02:41 -0400 X-Greylist: delayed 434 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 06:02:41 EDT IronPort-SDR: B+xH0zFmjQIIhZFtByEb1uFS4KP+tIhp/hdDsPEYoPils0TxuAu9obgiFv6DkNRPHceuPAEYMA xNs0//Q/78QQ== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="160590741" X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="160590741" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 02:55:20 -0700 IronPort-SDR: 6AWgY6k2jSM6QsujXaNtiiUDS/Fn+dL8VWCglFvIAk26Fo4St2OUfqS3ZchJAQuNrr212bTyNP sdO6q+0OmcHw== X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="452231616" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 02:55:16 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 17 Sep 2020 12:55:14 +0300 Date: Thu, 17 Sep 2020 12:55:14 +0300 From: Mika Westerberg To: Bartosz Golaszewski Cc: Linus Walleij , Andy Shevchenko , Kent Gibson , Anders Roxell , linux-gpio@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH next v2] gpiolib: check for parent device in devprop_gpiochip_set_names() Message-ID: <20200917095514.GO2495@lahna.fi.intel.com> References: <20200917074857.6716-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917074857.6716-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 09:48:57AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > It's possible for a GPIO chip to not have a parent device (whose > properties we inspect for 'gpio-line-names'). In this case we should > simply return from devprop_gpiochip_set_names(). Add an appropriate > check for this use-case. > > Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") > Reported-by: Anders Roxell > Signed-off-by: Bartosz Golaszewski > Reviewed-by: Andy Shevchenko > Tested-by: Anders Roxell FWIW, Reviewed-by: Mika Westerberg