Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp321117pxk; Thu, 17 Sep 2020 04:08:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwKTC62XtuuDOFrGA7ofpo0BAIKPqItsErCN1v4y+HNGGY+8vsrJ6D0TuKOBMPmwSenDK4 X-Received: by 2002:a17:906:88d:: with SMTP id n13mr30795206eje.75.1600340922292; Thu, 17 Sep 2020 04:08:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600340922; cv=none; d=google.com; s=arc-20160816; b=E94dTk1sRDeayu239bMi6ugNOzA9DZ400dkvG4yxL4VUaNnqmfw5ii2mRrg2rjqA0m 40K6oULlCBj5N5MomBVQTdg9LyQlSYBWWSgAPAYeSWTJGUpfKHVJF0ah8pnTEbjpvwsY ImQdGUNcJgt6/J208d8WktNr21K+/o0+2cvmgWDkaStl3QnN34uHQL0G+rrX0cIUVqbk DlXG8LM1ofufkeFaGt6XKpaUmCNeNuHYGJi5Xp4CwHHi0r01VDyxfDxdubInRPzfFDHl 0YQoYlwON86DotdoJCC/sU83lxwtyE5rHdQ4t+yYKXYkU2U8Lt7c/goy0hQxFwruEdxs 9f8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OdHAXHjMblhRf+aKdhFARZxGWD7QjxXDUQvSsNkxEgk=; b=PXhl5hyhkop2OC56qMq224CwKchYUi8b9ssEk4zvtXeKE5sMVb9HW+fA/4EWALlkdO yPQo/KUeJSpjrWeT7h3zVqrdL2caw30I35pdVOfzA8PgnVyUPiq4mMFb/l8TFfRkmwEj /gXQZcoRoqndPaOQAkWfSM0A1vSh65n1KNfcyeTkx7okUay6RuOH2Nvtqja9O34hK6rB N1i0McYktyLG8reVmUoqLZo2qm0Wl/azEFjf7pntoaliMRMV4iLeGVjwCzz/NW9vl+Va 8JxCHB9czA0ufzpdcrvp943bDSX3GpEIZyQiP4vhXTcAxqMF/5asD+FPRzmMrfTBTKFM konA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1ccLIq0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si14496539edv.283.2020.09.17.04.08.18; Thu, 17 Sep 2020 04:08:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1ccLIq0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgIQLF6 (ORCPT + 99 others); Thu, 17 Sep 2020 07:05:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:38060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbgIQLDZ (ORCPT ); Thu, 17 Sep 2020 07:03:25 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D74522076D; Thu, 17 Sep 2020 11:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600340503; bh=aPCEwcIAuMvYoCEBtOQo2eERHoS019qUBYLdVY0/hTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1ccLIq0l0KnciBSQeBF5gPuenyxYph0LJQ4FgwgULOzMRDnR8LzMTkkgaclkQ6UOy BHB6aUZLthOo8hUIvk2Cgr43XmGm9QSZr1+/9U9L1iBbPajP4pWOXKfFHocssoYmDM iXVEVmsro/blj+Bt9nPVVgCsq0g3ZRBa7MDjEk0k= Date: Thu, 17 Sep 2020 12:00:53 +0100 From: Mark Brown To: Alban Bedel Cc: linux-hwmon@vger.kernel.org, Jean Delvare , Guenter Roeck , Rob Herring , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200917110053.GA4755@sirena.org.uk> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: <20200917101819.32045-4-alban.bedel@aerq.com> X-Cookie: If you fail to plan, plan to fail. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote: > + data->vs = devm_regulator_get_optional(dev, "vs"); > + if (IS_ERR(data->vs)) { Unless the device can work without power you should not be using regulator_get_optional(). --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9jQeQACgkQJNaLcl1U h9B2Jwf9FsOfhx52XRbTX0EQlV1uzHXTjKYKY0f/VVzp1/NtZQjgJW/qzpGIstuH JgAoa98HRd+Dd7MSfrLgDepC1+7MHNaMlFL4Dv28/V9NkM9atu9dvxduwckp+1sR sIdeHldh7jw5Tmjz5dmKbKbWn17r5MX4eTR8pv1hZlKfCraIIVMq145NgBiV0q6R JurB8qhGznwolBc4hHz6X+rAyNo+ZrvE/hsfxtKaXVjziSQwgRopaSbXlD5pTYsD teudpthwvxrG9lg/HVY+WAaBhpNxHSLKfr7IMV1tptOqxRvnOKn+c+6/CicnpZiZ fDHkDqIsFPj98T7sHutzo79R6A6xHw== =XT8Y -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--