Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 13:12:27 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Rob Herring <robh@kernel.org>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
        Stephan Gerhold <stephan@gerhold.net>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Mark Brown <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Heiko Stuebner <heiko@sntech.de>,
        Josua Mayer <josua.mayer@jm0.eu>,
        Andreas Kemnade <andreas@kemnade.info>,
        Arnd Bergmann <arnd@arndb.de>, Daniel Palmer <daniel@0x0f.com>
Subject: Re: [PATCH v2 02/10] dt-bindings: mfd: Add binding for Netronix's
 embedded controller
Message-ID: <20200917111227.GG3306@latitude>
References: <20200905133230.1014581-1-j.neuschaefer@gmx.net>
 <20200905133230.1014581-3-j.neuschaefer@gmx.net>
 <20200915005034.GA593718@bogus>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Qf1oXS95uex85X0R"
Content-Disposition: inline
In-Reply-To: <20200915005034.GA593718@bogus>
Precedence: bulk


--Qf1oXS95uex85X0R
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 14, 2020 at 06:50:34PM -0600, Rob Herring wrote:
> On Sat, Sep 05, 2020 at 03:32:22PM +0200, Jonathan Neusch=C3=A4fer wrote:
> > This EC is found in e-book readers of multiple brands (e.g. Kobo,
> > Tolino), and is typically implemented as a TI MSP430 microcontroller.
[...]

> > +required:
> > +  - compatible
> > +  - reg
>=20
> additionalProperties: false

Ok, I'll add that.

> > +                    interrupt-controller;
> > +                    #interrupt-cells =3D <1>;
>=20
> These need to be documented too.

Interrupt support is something I haven't really worked out yet for this
(set of) binding(s). My idea here was to have the embedded-controller
node act as an interrupt controller, and the subnodes use specific
interrupts that are relevant for their functionality.

I think I'll rather omit the interrupt-controller and #interrupt-cells
properties now, and add them later if they become necessary. If the pwm
and rtc nodes are merged into the main node, I don't think they will
become necessary.


Thanks,
Jonathan Neusch=C3=A4fer

--Qf1oXS95uex85X0R
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl9jRJQACgkQCDBEmo7z
X9u8KRAAq5gEP5j/6Hqan0bWxs+pnmxfLfJWotg/zYwxGSXKbNeJs5wWVQ1A+Pni
DZFAl1Ai4HcClf/OEA4dU4goQrfPUwunWBXZtzRWtjyssikgRn/Ppkt/Xw8p1zZ/
xxJqR4GD1N3jaP8G1/w8TbTLNSCXuYXh3mV8bfM8PHvBf8R5rGqDLeCP2qdUQKNu
LrO7CNsUNwBwbT+/9H8i9/DLuZCiiFk3RrY9/hTS2dkIYuuJUWnzjB7TLapSNvAS
hN/58HFgjheT7YpmicfOCyGjPCV2o407QDsQN4sEiFn83dk/E1Uz9kizLuvPzzF3
ZUbmlWSGpejZWHM9RBPf9ZRwDtQFu7h7vutQ9U+2Drk+jpVD72fOgBCraAq7wndy
riFBUSvFm+jtFjZ7Z597JuMMuU1pUYv7lUxt/0D0svNGq/tTMU8mYZAxKq9XAvOb
uA9bMxXUjj/wIMK444K8gBtmMZnK/XZhUiqffKm0xuiEUzKPJIVok/5sTLroil10
vNzVBrjQb3fO/sKeB5jLbr7QJ426aYHF+nI1mGC44FM0LiAo3F/+B4VwGgDhhRAh
zrRVgrXDe/YO+yjR1+1E1NmU0CZ6C2dbdLJr3mf+T7RxHsmZ99JCZb9TFSThGP6U
gKdiSgi+T11HDeQXw559Uhf+mLivOh+20AAj+RSOg+F2NDYQS/Y=
=Luic
-----END PGP SIGNATURE-----

--Qf1oXS95uex85X0R--