Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp329934pxk; Thu, 17 Sep 2020 04:23:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwe9BNXr69d6C293ZJbd8lYxjPw2Qyn8DumEMqpagJX4ty9nFB4E0K+5ShAQQ29Qz339TUV X-Received: by 2002:a17:906:35d5:: with SMTP id p21mr29797737ejb.194.1600341822613; Thu, 17 Sep 2020 04:23:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600341822; cv=none; d=google.com; s=arc-20160816; b=pG2mdqhQM3I+OlHTcaAc5uRP8hiBOMlnKInB+/qDqCr3LmUgZNrmaYdUXOZJ/BiUUZ hme6gRP5b8x7MUq4i8d17VCBFy7XsWCSg6EEQZF+jqQArwXsJC0TW3VeLaqKTq/TPva+ HeBSWsLbnkA3gchQFNr1JRP/ZRRv78uNQ7mGIsVVcHih9lC6l5LlUXE5WNsw35a6nEPm EQBZWZflrcQOgONMW+I2UfaA5mIBfRjwcy11huH9G39flzUljxMIRc/y35MeCruLb6Wx AIEOXcL1eL/sbrUHdUafFKS6SEiqgPyJ8sxiiI9xQkqutGX+MyYyDFuZlKSFRgyXVnmX L5Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=s0Mn6hVpuDmYvya0vHUcmwuT1TeYzUj9E6j9cQhWCVE=; b=Gsmq/z3XRkL8GaqdItGunD5Pxw/E/MBJigD8C7UP6paw9CKargXngfXOOR5W2glt05 TuxHZoJp8Fg/EG/Wq9rBGaM2HaBJxbfBIRYEgnkbeFnPSCahCgbxgdOoZSzMS+56aoD9 750zd5wJ9CUQG9aiZoU0iPJNf7wGIWtCFJb1IvOQsvWHtFp9UlRau8q7Foske9lNAgu3 B8zICayI3En54EyjiVbT8plY8GVsVe1g/S1ikKgSjl3T7fGRRZibMHU7J0iyHTUIKj4C 7cTyyjA3N9MNXE1G84NE0FMIBzyCYG/ZC2EQ545pv7dqRL7fKwg/kAsJtAjhGv/knQ9x mOfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lEkID1R4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si14496539edv.283.2020.09.17.04.23.19; Thu, 17 Sep 2020 04:23:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lEkID1R4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbgIQLVu (ORCPT + 99 others); Thu, 17 Sep 2020 07:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726723AbgIQLUk (ORCPT ); Thu, 17 Sep 2020 07:20:40 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23170C06174A; Thu, 17 Sep 2020 04:20:23 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id z9so1653554wmk.1; Thu, 17 Sep 2020 04:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s0Mn6hVpuDmYvya0vHUcmwuT1TeYzUj9E6j9cQhWCVE=; b=lEkID1R4JmGRGGsFR3W8WSDhN8QOSXYq8fSt67Q0iiFFT10AIWJ9IvZRyJE+kVvJbK upiGoGWPyiJ+jJDiPv89krXiNxIHAMU5qyVSUrIcwZm7Aoxql5UP7OSefuY5jdcySrsg PP297i3rBfvQrVIdK1WqqfsbKv46jDJOyAUO+8qRAdf589tTvI9BLZDFzWJmmiVf2c9K 2ylLWME8i3t607G4CyaO2+/oAoptunPCPlNMnltAMu0swIFbnlUCM1bSMqLf1U2PojBl GKh0ZdBc/ajpTecPymGfzYX1UE3mal/pB+k6TpAOaSBkM5jv+jAlC4rSn6QorybkK1ra dnUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s0Mn6hVpuDmYvya0vHUcmwuT1TeYzUj9E6j9cQhWCVE=; b=bDkvXkA/H02qoInCIXiAqaZPQ9VtlsrSQ5bBGsSBfbrzzpkCjA0OsquUFu6sPuIm/B M6Z5j9oIYjzwYGPbKlEr8YWcIJROJ2bTT0Rm771nGHf1S2QO9a66PkvPONue7w2pLygL QS02oL0BZPsPmZRADKBI57/BWkUW1Lfpkdv5KtGAqTCMNUGJOc52TVCnvAErzq1Ao1UO ZoR9/1k4ZRc4fQpPqVTizwcLQXeJk5CiFc/cAdJx8+3RIuG/tKyjEqnRxVIIGs5UnIxz 0tm0SR4cvXCgie4giN/YHbFDy1DLAObd6vOOvhxrn1IOGoPxDY0mfSgHE/6SwtZ8kH9x xJhA== X-Gm-Message-State: AOAM532E2PrC5mNjMoVfoNMW6+J23DZsiaW+HjCf/nk43iP+x6JB1tCx wsYKi+JvRKcNrQhRVpuUaaA= X-Received: by 2002:a1c:2543:: with SMTP id l64mr8926412wml.96.1600341621859; Thu, 17 Sep 2020 04:20:21 -0700 (PDT) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id y5sm10614528wmg.21.2020.09.17.04.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 04:20:20 -0700 (PDT) Date: Thu, 17 Sep 2020 13:20:18 +0200 From: Thierry Reding To: Dmitry Osipenko Cc: Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andy Shevchenko , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 05/34] i2c: tegra: Initialize div-clk rate unconditionally Message-ID: <20200917112018.GQ3515672@ulmo> References: <20200908224006.25636-1-digetx@gmail.com> <20200908224006.25636-6-digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i/CQJCAqWP/GQJtX" Content-Disposition: inline In-Reply-To: <20200908224006.25636-6-digetx@gmail.com> User-Agent: Mutt/1.14.6 (2020-07-11) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i/CQJCAqWP/GQJtX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 09, 2020 at 01:39:37AM +0300, Dmitry Osipenko wrote: > It doesn't make sense to conditionalize the div-clk rate changes because > rate is fixed and it won't ever change once it's set at the driver's probe > time. All further changes are NO-OPs because CCF caches rate and skips > rate-change if rate is unchanged. >=20 > Reviewed-by: Micha=C5=82 Miros=C5=82aw > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 34 ++++++++++++++++------------------ > 1 file changed, 16 insertions(+), 18 deletions(-) Acked-by: Thierry Reding --i/CQJCAqWP/GQJtX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9jRnIACgkQ3SOs138+ s6Gvxw//YIsUb30uhZmog+j2pWjI6/ggd39LPU513zqrD+KNY4X3RbKgmszrJPHx KmeG8a41F0D0/a8Nb10+54XkB9hfQY1eoLoia2yeNbjJu0Etb6+X6HPqaBKxfrCh S9oFiWgxiZX4XdKp/69aTqQB6xUd+/2+/IXRoQaaLuTLW30WHcB8rdun0qN3DfVU lpUv/YOYHW+AYKuKq2Pt3WsR5kemkF5qRginE5dlEHcN1qHWKy5edOzEFmccoILT 7s73zPf1SWsETLX3yOOtVmbmSkEywbbzg6SVVLdCM8g2IpHTQ9j0ZZj4lfWzt+GW 1RDnUCjaB289jqb8GnmzPrANnaOxj+jFTx3e/sndc0buPz37BcXmPQqAoQQMOTHa oJhBKAwRXSDBRmKpuResjS3wtM5SD1ZoAZnRO3OmmnnKbQeAGDqfjfvZSufrfOHs BqxhEJvfNr2tJ9gR9dll6YDP9erOQPEoDENBo8PH9I/XurVmOA08i3a/yIzFd9TV nU/LvcLQ05cCc9Un4T8PyBsQfJsSoHgXNvU0WbATOap3wvSc/IrcPzCDGcffSs2W TSxzuMImyz383wiCAT6O1FeMRtC9jCT0Ryg1syIks/xrWmqHcQPIS5bzH7AAtU0B QlkIHSHfqEa9W3P+hkK4UnUHuFEX2GztsShHzKWCysXq8vCu/M0= =VD5G -----END PGP SIGNATURE----- --i/CQJCAqWP/GQJtX--