Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 12:22:03 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Ricardo Ribalda Delgado <ribalda@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: Add support for 12/20 register formatting
Message-ID: <20200917112203.GB4755@sirena.org.uk>
References: <20200916160552.1062243-1-ribalda@kernel.org>
 <20200916162824.GC6374@sirena.org.uk>
 <CAPybu_20oay941cqHqa_D13cN0XCrk=Pa113ZuwbbAuVC3yX3A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz"
Content-Disposition: inline
In-Reply-To: <CAPybu_20oay941cqHqa_D13cN0XCrk=Pa113ZuwbbAuVC3yX3A@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--0eh6TmSyL6TZE2Uz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 17, 2020 at 08:31:54AM +0200, Ricardo Ribalda Delgado wrote:
> On Wed, Sep 16, 2020 at 6:29 PM Mark Brown <broonie@kernel.org> wrote:

> > What exactly is the format you're trying to describe here?  It sounds
> > like there's two blocks of padding in here (I'm assuing that's what
> > dummy means) but what's the exact arrangement here and what are the
> > commands?  It sounds like this might not work ideally with things like
> > the cache code (if it makes things seems sparser than they are) and
> > might not be obvious to someone looking at the datsheet.

> The format is

> XXXXCCCCAAAADDDDDDDDDDDDDDDDXXXX

> Where X is dont care, C is command, A is address and D is data bits. I

> Shall I add this to the commit message? I want to send a V2 anyway,
> because I screwed up the identity (ribalda.com instead of kernel.org)

Yes, please.  I was fairly sure it worked, it was just a question of if
it was ideal for the format described.  The only issue I can see with
the above is that the users will need to left shift their data - on the
face of it it would seem better to add a facility for padding the LSBs
of the data field to the core so that users can just use the data field
as documented.

--0eh6TmSyL6TZE2Uz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9jRtoACgkQJNaLcl1U
h9DgFAf6AkNxuuI8Zoyx+GO304rvAN+N5MpZtKzDRjgd/DwBvU2adlMGVEtuo+dt
lCyR1lTifzXAhtAjutlNXUqGQ+Ya+s9sZfKfpVmjDO0dIAoZGFMUB5I4DnKIUdO8
P+NSAcsqOUvq1SFvMP/gXmzyoRJWR6m4QCbljqXsBEH6NLFFnGhvzmiJ67tJSJcn
OhsFTNK9sYKiCyAWsi50xf7TdlfZ2NH2xUiJf9s9fV5FwhLu8i8wG7fkeeYMBXIc
3Y8I1lYRVtyTSpodKk3v7h9eOixXUzFF8Bg90NBEoTeXHyo9h1jrbNjWosEwi8Fa
90+wycHhIrm9PcO4V8K1hoCcJxBtGw==
=FTWa
-----END PGP SIGNATURE-----

--0eh6TmSyL6TZE2Uz--