Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 13:44:27 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 20/34] i2c: tegra: Remove "dma" variable from
 tegra_i2c_xfer_msg()
Message-ID: <20200917114427.GY3515672@ulmo>
References: <20200908224006.25636-1-digetx@gmail.com>
 <20200908224006.25636-21-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Tln/wzp9jsNjmSUr"
Content-Disposition: inline
In-Reply-To: <20200908224006.25636-21-digetx@gmail.com>
User-Agent: Mutt/1.14.6 (2020-07-11)
Precedence: bulk


--Tln/wzp9jsNjmSUr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 09, 2020 at 01:39:52AM +0300, Dmitry Osipenko wrote:
> The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in
> regards to readability and generation of the code.
>=20
> Besides readability, it's also not very nice that the is_curr_dma_xfer
> is initialized in tegra_i2c_xfer_msg() and then could be overridden by
> tegra_i2c_config_fifo_trig(). In a result, the "dma" variable creates
> slight confusion since it's not instantly obvious why it's set after
> tegra_i2c_config_fifo_trig().
>=20
> Hence should be better to have the variable removed. This makes code
> more consistent.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

--Tln/wzp9jsNjmSUr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9jTBsACgkQ3SOs138+
s6G1HQ//X2i75V4eshvomPdZxueOPlRm94R+wDAKAPtQvOlwON++lsuhDyUY5jSG
8g+XLWb9KUmIWl9ZS/hItiD0OfPWyssa1yoIqGp7FIL5RZooCfJjRhf2bf7Bp8cC
xdheoPdHxpAGEb23UQ0tt55RsJLmsxu0wde3WXnmMzxw2ApMo4SOAngkFQLYldA5
POOen4bcCGQuAx2JaJPqIbzft+G/tC9smaoH1hdsifNOHoRa6yetXvXTLw4VYmUv
VdiyK2KXZXR6sSZk0fS8XSL5wZEqPbs4YXpkcr3rnXewP/BHMkpnWSYoLZbVzxiE
CnBB2XI83qdAJBUfyqP+mQ7AE9MRRXzR++yze8h+TaXbAF+957Xo0VadaES9lTLe
tifsCA7ImTKtB9h7G/YjJnpxaKQUtODChzF4aIQX3I/0oDLlnzeBShMngCRlPZ+b
mJ0smwdlGtk/F+i2IdtcRr4gWNf9JI/Exvqsjz4BnwR+5FBAs3Ou7KLgscrXIROP
+2sCzrXAYd6pDjypICEyNjb9w1iwMRy7rxVa5dcPglfTbd0keJZiQ63WE2Y8kyEb
SpAFhxhtzYmlksvHj/pDng+9tJu2deJL6Fqr1GiYDWI39yhIiqUCDr9v7IO0xOs5
9FTQCBATFaRLR04hh2E2RDZVneKhawDYVZFQUaTaH1vjB3jv14M=
=wy4C
-----END PGP SIGNATURE-----

--Tln/wzp9jsNjmSUr--