Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp388394pxk; Thu, 17 Sep 2020 06:00:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0Ml7Up6iGMvPR+pBp37tL6d7cWQRgTt/F+xuv8dItJymczCr7mfYtsmA29ZdkIkKDZYoP X-Received: by 2002:aa7:d30b:: with SMTP id p11mr33041647edq.80.1600347627636; Thu, 17 Sep 2020 06:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600347627; cv=none; d=google.com; s=arc-20160816; b=FxJMko4ZcgCdklV4sYPEpPZc0t2jTPScEfqRt3/nd2XHssiTNdBw0EM5WfeJV7/dFN dFVEVe+K85AaLhzBVT6cdA2RrL/Qz4qQqa293rtXACqWME1nfPnSFFdqyB/PceqEHhpe lPwkv1JuW6BnuIt7V1vvLWC+e02567xJYfwDKNWB5eza3BpLuZljGWSUqzj7q8rJyFAB FwdPC7xno4EPwqBJi+2yRumUoa0f4Y++VB19toRfUgxGBSNYnFEwTF7+IqFbNJre17xU oK55TlSBLQjBx9s2xzs+sB67l2lxzn7R4TLnMAcSAkw1MrBiOFybphyDHQ61vobu5B9S /AOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zigK1ziLNhzj7skT0NrY1Zr3xEMqh+3ghMO9u49NcwI=; b=hwKWKkjO0qitkZaBgDwBi3J5kui0p0ZZuBGZCMjsbZ+0CMQwTJJauYTMytG4X1JjZd 0XeT3T4egx9//0zuVSn+FAK9Bt3fV3AmAaLfLBI4EhiEc3daP/mPdqT09+wFiasq9NIm z+CQFU6WHNZIBGetG/YN4pQMDDBF3ZfN/6tAzRLhWsalYd5oHu6KPyd7qaRNIIUdorT0 Zrm0wzP1meJe5FIkkpTjhaCTIvpPypsxDHP9hqgyYrC+5bIk9CD1BSoSO6W4FNVZmIFt zTqA7W2uZwuqI0zCDBfM5sjXh3RHnWstV/JUr5YY7N8SYFM37gN5Uy8fO43sjyIyeads JGfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt20si13240657ejc.527.2020.09.17.06.00.02; Thu, 17 Sep 2020 06:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbgIQM6Q (ORCPT + 99 others); Thu, 17 Sep 2020 08:58:16 -0400 Received: from mailout12.rmx.de ([94.199.88.78]:59194 "EHLO mailout12.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726823AbgIQM6J (ORCPT ); Thu, 17 Sep 2020 08:58:09 -0400 Received: from kdin01.retarus.com (kdin01.dmz1.retloc [172.19.17.48]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout12.rmx.de (Postfix) with ESMTPS id 4BsbhM6kVbzRnbH; Thu, 17 Sep 2020 14:22:43 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin01.retarus.com (Postfix) with ESMTPS id 4BsbgT1D7qz2xKS; Thu, 17 Sep 2020 14:21:57 +0200 (CEST) Received: from N95HX1G2.wgnetz.xx (192.168.54.80) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Sep 2020 14:21:47 +0200 From: Christian Eggers To: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam CC: Pengutronix Kernel Team , NXP Linux Team , , , , Christian Eggers , Subject: [PATCH 2/3] i2c: imx: Check for I2SR_IAL after every byte Date: Thu, 17 Sep 2020 14:20:28 +0200 Message-ID: <20200917122029.11121-3-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200917122029.11121-1-ceggers@arri.de> References: <20200917122029.11121-1-ceggers@arri.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.54.80] X-RMX-ID: 20200917-142203-4BsbgT1D7qz2xKS-0@kdin01 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arbitration Lost (IAL) can happen after every single byte transfer. If arbitration is lost, the I2C hardware will autonomously switch from master mode to slave. If a transfer is not aborted in this state, consecutive transfers will not be executed by the hardware and will timeout. Signed-off-by: Christian Eggers Cc: stable@vger.kernel.org --- drivers/i2c/busses/i2c-imx.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index d8b2e632dd10..9d9b668ec7f2 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -479,6 +479,20 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx, bool atomic) dev_dbg(&i2c_imx->adapter.dev, "<%s> Timeout\n", __func__); return -ETIMEDOUT; } + + /* check for arbitration lost */ + if (i2c_imx->i2csr & I2SR_IAL) { + unsigned int temp = i2c_imx->i2csr; + + dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__); + temp &= ~I2SR_IAL; + temp |= (i2c_imx->hwdata->i2sr_clr_opcode & I2SR_IAL); + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2SR); + + i2c_imx->i2csr = 0; + return -EAGAIN; + } + dev_dbg(&i2c_imx->adapter.dev, "<%s> TRX complete\n", __func__); i2c_imx->i2csr = 0; return 0; -- Christian Eggers Embedded software developer Arnold & Richter Cine Technik GmbH & Co. Betriebs KG Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477 Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler