Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp459367pxk; Thu, 17 Sep 2020 07:35:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaEOAWh82vIoATkEHMBCOWxQWcsyt/8ma6dzUG17GpD8r8H9oQ1lH9KH/W1UuB9fanHiPR X-Received: by 2002:a17:906:2b06:: with SMTP id a6mr30843611ejg.209.1600353348979; Thu, 17 Sep 2020 07:35:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600353348; cv=none; d=google.com; s=arc-20160816; b=A2zh4gW1u2FL+BLFCWYP1WIY9WwZsOww0AfaqN15fpr4L/8/mHGLmjWuoQCuT0O9A9 QFhRJjXl/vCHEkzU2g+y5mwt28y9pLBd6VvYD3dX1oFO4HvcFi5uMApGVyEiykiUxtoD kjK7SM+44Yj+FiExoyCAb38afQEYPYxEjGUqeVZLoQvaWkaZtUsJ8Wb/iu3WtPeY/zdb umAdeegL3gepI5J/HRPbkKf5xxAUDwnae3iCvXlhWVG57OnhIbsNSLd/Y8iPoFHafoEb gv+gsfucU2AVukbiFxH+sZjmdC9XG4BbCnhbqZidMOZrJyFGO4GfLWJ9daJcBjNU1Smy cBgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=lg/T0bUlY4lb0hy9zy/UrD8J01AIKFECWlffkInNKdc=; b=PU+JIzda8GUn6cF11YyNPPW1njNK/KYXBJuYUwJ183qE2MHF4fuXm9UVay5127LTV8 sH8sKku+Rl5bbFAYagiRISX5dBQW9VbWUz/DCntHRZ06wR60cvI99OG0qPm7x+g7RVKq Ss49eD6Do7XUgkKI5Kq/fnBYqcD9nnlui6AzcKgLPlR+nAMGar8DPxTz8NB1GNnZ8Gok VVyr29Z0NmpEkiboS4mSVJoYgBuGcmNcT0uqNduLEWw3700m1L3LueDEx6Wl9/ELVnOE jx6Ii8bKf6n9lyrkBekiITRQbR0nHrJ0gdd0KbTGxXnNkvcj6yoltOm8jg42/hgJhsZr jyoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=EvjzTy8Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si61349ejp.429.2020.09.17.07.35.22; Thu, 17 Sep 2020 07:35:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=EvjzTy8Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727623AbgIQObu (ORCPT + 99 others); Thu, 17 Sep 2020 10:31:50 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:1392 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727560AbgIQOaf (ORCPT ); Thu, 17 Sep 2020 10:30:35 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08HDKtbm185587; Thu, 17 Sep 2020 09:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=lg/T0bUlY4lb0hy9zy/UrD8J01AIKFECWlffkInNKdc=; b=EvjzTy8QQFfJ2hlMfdq1ZOl/jPzrfE/bdzv0zOmZlHnA8PHzseo78Y+EYa6tCqVrDpxu W5/YC/lBe0/YD4mNtbTk7+GArjIhkvteOYVmAtHXhWB2tKaGDaCOLOlvKFlZDF/CGWII NVDcDE6mQw+t46MnGwsd5wwVYnCUHf6bnQHlSVKSGKAeYGx2cLiu9GStUC2ijOe7M5fU 1aYK0iKAEjT/MLgA6SIZgrpe/RyaDdaJ1nvn4AnN6jflhKmPGwzFnCjfSTqQrwNP7D4T sj/8ol4plkegberzof46ay+PMTMVDX+c8gefWelH//kotmkQCfbISN6gamPmxqSpcyeY FA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 33m8kr836w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Sep 2020 09:25:38 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08HDMJ7Q194042; Thu, 17 Sep 2020 09:25:38 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 33m8kr8368-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Sep 2020 09:25:38 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08HDMbmM008410; Thu, 17 Sep 2020 13:25:37 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03dal.us.ibm.com with ESMTP id 33k5v20xef-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Sep 2020 13:25:37 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08HDPaaa30998818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2020 13:25:36 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6EB96AE05F; Thu, 17 Sep 2020 13:25:36 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 00D64AE064; Thu, 17 Sep 2020 13:25:33 +0000 (GMT) Received: from localhost.localdomain (unknown [9.211.95.89]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 17 Sep 2020 13:25:32 +0000 (GMT) Subject: Re: [PATCH v6 2/8] powerpc/watchpoint: Fix handling of vector instructions To: Ravi Bangoria , mpe@ellerman.id.au, christophe.leroy@c-s.fr Cc: mikey@neuling.org, jniethe5@gmail.com, pedromfc@linux.ibm.com, linux-kernel@vger.kernel.org, paulus@samba.org, rogealve@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org References: <20200902042945.129369-1-ravi.bangoria@linux.ibm.com> <20200902042945.129369-3-ravi.bangoria@linux.ibm.com> From: Rogerio Alves Message-ID: <45936ae1-5150-a0f0-1b82-1689b9f729c3@linux.ibm.com> Date: Thu, 17 Sep 2020 10:25:31 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200902042945.129369-3-ravi.bangoria@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-17_09:2020-09-16,2020-09-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170098 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/20 1:29 AM, Ravi Bangoria wrote: > Vector load/store instructions are special because they are always > aligned. Thus unaligned EA needs to be aligned down before comparing > it with watch ranges. Otherwise we might consider valid event as > invalid. > > Fixes: 74c6881019b7 ("powerpc/watchpoint: Prepare handler to handle more than one watchpoint") > Signed-off-by: Ravi Bangoria Tested-by: Rogerio Alves > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c > index 9f7df1c37233..f6b24838ca3c 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -644,6 +644,8 @@ static void get_instr_detail(struct pt_regs *regs, struct ppc_inst *instr, > if (*type == CACHEOP) { > *size = cache_op_size(); > *ea &= ~(*size - 1); > + } else if (*type == LOAD_VMX || *type == STORE_VMX) { > + *ea &= ~(*size - 1); > } > } > >