Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200908213715.3553098-1-arnd@arndb.de> <20200912070922.GA1945@infradead.org>
In-Reply-To: <20200912070922.GA1945@infradead.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 17 Sep 2020 17:02:16 +0200
Message-ID: <CAK8P3a085LEAtMagNm0++UHGKjntYE-6yg_6+VzG96a-hgia_Q@mail.gmail.com>
Subject: Re: [PATCH 1/3] scsi: aacraid: improve compat_ioctl handlers
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Balsundar P <balsundar.p@microsemi.com>,
        Zou Wei <zou_wei@huawei.com>, Hannes Reinecke <hare@suse.de>,
        Sagar Biradar <Sagar.Biradar@microchip.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 12, 2020 at 9:09 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Tue, Sep 08, 2020 at 11:36:21PM +0200, Arnd Bergmann wrote:
> > @@ -243,8 +244,23 @@ static int next_getadapter_fib(struct aac_dev * dev, void __user *arg)
> >       struct list_head * entry;
> >       unsigned long flags;
> >
> > -     if(copy_from_user((void *)&f, arg, sizeof(struct fib_ioctl)))
> > -             return -EFAULT;
> > +     if (in_compat_syscall()) {
> > +             struct compat_fib_ioctl {
> > +                     u32     fibctx;
> > +                     s32     wait;
> > +                     compat_uptr_t fib;
> > +             } cf;
>
> I find the struct declaration deep down in the function a little
> annoying.
>
> But otherwise this looks good;
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

I got back to these patches now and moved the struct definition, plus
fixed a typo I noticed while doing so. Thanks!

      Arnd