Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 17:24:22 +0200
From:   Marek Behun <marek.behun@nic.cz>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     linux-leds@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Dan Murphy <dmurphy@ti.com>,
        Ond??ej Jirman <megous@megous.com>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        devicetree@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH leds v1 06/10] leds: pm8058: use struct led_init_data
 when registering
Message-ID: <20200917172422.5924d3af@nic.cz>
In-Reply-To: <20200917004625.GJ1893@yoga>
References: <20200916231650.11484-1-marek.behun@nic.cz>
        <20200916231650.11484-7-marek.behun@nic.cz>
        <20200917004625.GJ1893@yoga>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 16 Sep 2020 19:46:25 -0500
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:

> The pdev->dev -> dev and of_node changes are reasonable, but shouldn't
> be part of this patch. It simply makes it hard to reason about he actual
> change.
> 
> Please respin this with only the introduction of led_init_data.
> 
> Thanks,
> Bjorn
> 
Am working on this :)