Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200917034610.21703-1-dawning.pang@gmail.com> <e4ac75c6-ce1f-7d4e-9402-82f499392521@amd.com>
In-Reply-To: <e4ac75c6-ce1f-7d4e-9402-82f499392521@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 17 Sep 2020 11:35:43 -0400
Message-ID: <CADnq5_N4S9gOGPcgUzdkyF2svD3_4bxMyB=k9Px_ddyT-q3RTA@mail.gmail.com>
Subject: Re: [PATCH v1] powerplay:hwmgr - modify the return value
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Xiaoliang Pang <dawning.pang@gmail.com>,
        "Quan, Evan" <evan.quan@amd.com>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Kenneth Feng <kenneth.feng@amd.com>,
        zhengbin <zhengbin13@huawei.com>, pelle@vangils.xyz,
        Yintian Tao <yttao@amd.com>,
        Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>, Nirmoy Das <nirmoy.das@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Eric Huang <JinHuiEric.Huang@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Sep 17, 2020 at 4:28 AM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
>
> Am 17.09.20 um 05:46 schrieb Xiaoliang Pang:
> > modify the return value is -EINVAL
>
> Maybe better write something like "The correct return value should be
> -EINVAL." With that done feel free to add my acked-by.

Applied with updated commit message.

Thanks!

Alex


>
> Christian.
>
> >
> > Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (=
v5)")
> > Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 =
(v4)")
> > Cc: Eric Huang <JinHuiEric.Huang@amd.com>
> > Cc: Evan Quan <evan.quan@amd.com>
> > Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
> > ---
> >   drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
> >   drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drive=
rs/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> > index c378a000c934..7eada3098ffc 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> > @@ -4659,7 +4659,7 @@ static int vega10_display_configuration_changed_t=
ask(struct pp_hwmgr *hwmgr)
> >       if ((data->water_marks_bitmap & WaterMarksExist) &&
> >                       !(data->water_marks_bitmap & WaterMarksLoaded)) {
> >               result =3D smum_smc_table_manager(hwmgr, (uint8_t *)wm_ta=
ble, WMTABLE, false);
> > -             PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", =
return EINVAL);
> > +             PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", =
return -EINVAL);
> >               data->water_marks_bitmap |=3D WaterMarksLoaded;
> >       }
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drive=
rs/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > index a678a67f1c0d..04da52cea824 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > @@ -2390,7 +2390,7 @@ static int vega12_display_configuration_changed_t=
ask(struct pp_hwmgr *hwmgr)
> >                       !(data->water_marks_bitmap & WaterMarksLoaded)) {
> >               result =3D smum_smc_table_manager(hwmgr,
> >                                               (uint8_t *)wm_table, TABL=
E_WATERMARKS, false);
> > -             PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", =
return EINVAL);
> > +             PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", =
return -EINVAL);
> >               data->water_marks_bitmap |=3D WaterMarksLoaded;
> >       }
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel