Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 17 Sep 2020 17:44:32 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Qian Cai <cai@redhat.com>
Cc:     torvalds@linux-foundation.org, vgoyal@redhat.com,
        miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: slab-out-of-bounds in iov_iter_revert()
Message-ID: <20200917164432.GU3421308@ZenIV.linux.org.uk>
References: <20200911215903.GA16973@lca.pw>
 <20200911235511.GB3421308@ZenIV.linux.org.uk>
 <87ded87d232d9cf87c9c64495bf9190be0e0b6e8.camel@redhat.com>
 <20200917020440.GQ3421308@ZenIV.linux.org.uk>
 <20200917021439.GA31009@ZenIV.linux.org.uk>
 <e815399a4a123aa7cc096a55055f103874db1e75.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e815399a4a123aa7cc096a55055f103874db1e75.camel@redhat.com>
Precedence: bulk

On Thu, Sep 17, 2020 at 10:10:27AM -0400, Qian Cai wrote:

> [   81.942909]  generic_file_read_iter+0x23b/0x4b0
> [   81.942918]  fuse_file_read_iter+0x280/0x4e0 [fuse]
> [   81.942931]  ? fuse_direct_IO+0xd30/0xd30 [fuse]
> [   81.942949]  ? _raw_spin_lock_irqsave+0x80/0xe0
> [   81.942957]  ? timerqueue_add+0x15e/0x280
> [   81.942960]  ? _raw_spin_lock_irqsave+0x80/0xe0
> [   81.942966]  new_sync_read+0x3b7/0x620
> [   81.942968]  ? __ia32_sys_llseek+0x2e0/0x2e0

Interesting...  Basic logics in there:
	->direct_IO() might consume more (on iov_iter_get_pages()
and friends) than it actually reads.  We want to revert the
excess.  Suppose by the time we call ->direct_IO() we had
N bytes already consumed and C bytes left.  We expect that
after ->direct_IO() returns K, we have C' bytes left, N + (C - C')
consumed and N + K out of those actually read.  So we revert by
C - K - C'.  You end up trying to revert beyond the beginning.

	Use of iov_iter_truncate() is problematic here, since it
changes the amount of data left without having consumed anything.
Basically, it changes the position of end, and the logics in the
caller expects that to remain unchanged.  iov_iter_reexpand() use
should restore the position of end.

	How much IO does it take to trigger that on your reproducer?