Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200917131515.147029-1-jingxiangfeng@huawei.com>
In-Reply-To: <20200917131515.147029-1-jingxiangfeng@huawei.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 17 Sep 2020 10:36:43 -0700
Message-ID: <CAKwvOdnm-PkEt6T3HqB-NYNYADth0MJkXCvFsc-_gyqRE-nmcg@mail.gmail.com>
Subject: Re: [PATCH] fbcon: Remove the superfluous break
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>, daniel.vetter@ffwll.ch,
        jirislaby@kernel.org, Nathan Chancellor <natechancellor@gmail.com>,
        george.kennedy@oracle.com, peda@axentia.se,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-fbdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Joe Perches <joe@perches.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> Remove the superfuous break, as there is a 'return' before it.

superfluous (missed "l")

>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for the patch; I audited the rest of the switch statements in
this translation unit; LGTM.

> ---
>  drivers/video/fbdev/core/fbcon.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>                                     vc->vc_video_erase_char,
>                                     vc->vc_size_row * count);
>                         return true;
> -                       break;
>
>                 case SCROLL_WRAP_MOVE:
>                         if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>                                     vc->vc_video_erase_char,
>                                     vc->vc_size_row * count);
>                         return true;
> -                       break;
>
>                 case SCROLL_WRAP_MOVE:
>                         if (b - t - count > 3 * vc->vc_rows >> 2) {
> --
> 2.17.1
>


-- 
Thanks,
~Nick Desaulniers